migrate RPCPointProducer to a global::EDProducer (75x) #10935

fwyzard · 2015-08-25T01:09:39Z

migrate RPCPointProducer to a global::EDProducer

…eir own files in the process: - rename ObjectMap to DTObjectMap - rename ObjectMapCSC to CSCObjectMap - merge multiple copies

- change all configuration parameters into const members - initialise them in the member initializer list - remove unused methods and member variables - change into a global::EDProducer

fwyzard · 2015-08-25T01:09:54Z

backport #10927 to 75x

cmsbuild · 2015-08-25T01:11:12Z

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_5_X.

migrate RPCPointProducer to a global::EDProducer (75x)

It involves the following packages:

HLTrigger/Configuration
HLTrigger/special
RecoLocalMuon/RPCRecHit
Validation/RPCRecHits

@perrotta, @cmsbuild, @cvuosalo, @fwyzard, @Martin-Grunewald, @deguio, @slava77, @danduggan can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @bellan, @jalimena, @geoff-smith, @jhgoh this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

fwyzard · 2015-08-25T01:16:41Z

@cmsbuild please test

fwyzard · 2015-08-25T01:18:22Z

RecoLocalMuon/RPCRecHit/src/CSCObjectMap.cc

+
+std::set<RPCDetId> const& CSCObjectMap::getRolls(CSCStationIndex index) const
+{
+  // FIXME


here I have kept the same behaviour as the previous implementation, which allows for NOT finding the given index in the map; a muon expert should check that this is the intended behaviour.

cmsbuild · 2015-08-25T01:21:14Z

The tests are being triggered in jenkins.

cmsbuild · 2015-08-25T03:22:04Z

-1

Tested at: 6db6fbd
I found errors in the following addon tests:

cmsRun /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-08-24-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Aug 25 05:16:00 2015-date Tue Aug 25 05:05:44 2015 s - exit: 16640
cmsRun /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-08-24-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Aug 25 05:09:25 2015-date Tue Aug 25 05:06:30 2015 s - exit: 16640

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10935/7625/summary.html

cmsbuild · 2015-08-25T04:08:29Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10935/7625/summary.html

fwyzard · 2015-08-25T09:15:11Z

hi @Martin-Grunewald ,
do you know what configuration is being run by the two failed tests [1] [2] ?

Martin-Grunewald · 2015-08-25T09:22:58Z

@fwyzard
The two "Fake" tests run real-data and MC of the Run-I so called "Fake" (stripped-down) menu.
As such they are using Run-I GTs which may not contain the payloads now needed with this PR.

fwyzard · 2015-08-25T09:41:42Z

@Martin-Grunewald
the error comes from the two new ESProducers, which are added in customizeHLTforCMSSW.py , even though they should not be needed for the "fake" HLT menu.
I'll try to restrict the customisation to run only when it's needed.

cmsbuild · 2015-08-28T08:47:04Z

Pull request #10935 was updated. @cmsbuild, @cvuosalo, @danduggan, @deguio, @slava77 can you please check and sign again.

cmsbuild · 2015-08-28T11:22:24Z

+1
Tested at: 52ab8d1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10935/7708/summary.html

cmsbuild · 2015-08-28T12:19:41Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10935/7708/summary.html

danduggan · 2015-08-28T12:40:08Z

+1

On Fri, Aug 28, 2015 at 1:22 PM, cmsbuild notifications@github.com wrote:

+1
Tested at: 52ab8d1
52ab8d1

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10935/7708/summary.html

—
Reply to this email directly or view it on GitHub
#10935 (comment).

slava77 · 2015-08-28T16:05:22Z

+1

for #10935 52ab8d1

changes since the last sign off ( fwyzard/cmssw@648574f...52ab8d1 ) are the same as in more cleanup of RecoLocalMuon/RPCRecHit #11000
jenkins tests show no differences in HLT DQM plots (the module is not running in RECO step)

cmsbuild · 2015-08-28T16:07:30Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 · 2015-09-04T07:22:15Z

+1

…part2 migrate RPCPointProducer to a global::EDProducer (75x)

fwyzard added 4 commits August 25, 2015 01:48

move CSCObjectMap, CSCStationIndex, DTObjectMap, DTStationIndex to th…

fcfdd4f

…eir own files in the process: - rename ObjectMap to DTObjectMap - rename ObjectMapCSC to CSCObjectMap - merge multiple copies

move DTObjectMap and CSCObjectMap to the EventSetup

51d50ff

RPCPointProducer: change into a global::EDProducer

9659695

- change all configuration parameters into const members - initialise them in the member initializer list - remove unused methods and member variables - change into a global::EDProducer

fix #include syntax

a280cca

cmsbuild added this to the Next CMSSW_7_5_X milestone Aug 25, 2015

cmsbuild added reconstruction-pending dqm-pending hlt-pending pending-signatures tests-pending orp-pending comparison-pending labels Aug 25, 2015

fwyzard mentioned this pull request Aug 25, 2015

migrate RPCPointProducer to a global::EDProducer #10927

Closed

fwyzard reviewed Aug 25, 2015
View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Aug 25, 2015

cmsbuild added tests-rejected and removed tests-started labels Aug 25, 2015

cmsbuild added comparison-available and removed comparison-pending labels Aug 25, 2015

cmsbuild added reconstruction-pending dqm-pending pending-signatures tests-pending comparison-pending labels Aug 28, 2015

cmsbuild added tests-started and removed tests-pending labels Aug 28, 2015

cmsbuild added tests-approved and removed tests-started labels Aug 28, 2015

cmsbuild added comparison-available and removed comparison-pending labels Aug 28, 2015

cmsbuild added dqm-approved and removed dqm-pending labels Aug 28, 2015

cmsbuild added reconstruction-approved fully-signed and removed pending-signatures reconstruction-pending labels Aug 28, 2015

cmsbuild added orp-approved and removed orp-pending labels Sep 4, 2015

cmsbuild added a commit that referenced this pull request Sep 4, 2015

Merge pull request #10935 from fwyzard/migrate_to_multithreading_75x_…

e739969

…part2 migrate RPCPointProducer to a global::EDProducer (75x)

cmsbuild merged commit e739969 into cms-sw:CMSSW_7_5_X Sep 4, 2015

fwyzard mentioned this pull request Sep 21, 2015

multithreading fix for 74x: RPCPointProducer #11355

Merged

fwyzard deleted the migrate_to_multithreading_75x_part2 branch September 23, 2015 19:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

migrate RPCPointProducer to a global::EDProducer (75x) #10935

migrate RPCPointProducer to a global::EDProducer (75x) #10935

fwyzard commented Aug 25, 2015

fwyzard commented Aug 25, 2015

cmsbuild commented Aug 25, 2015

fwyzard commented Aug 25, 2015

fwyzard Aug 25, 2015

cmsbuild commented Aug 25, 2015

cmsbuild commented Aug 25, 2015

cmsbuild commented Aug 25, 2015

fwyzard commented Aug 25, 2015

Martin-Grunewald commented Aug 25, 2015

fwyzard commented Aug 25, 2015

cmsbuild commented Aug 28, 2015

cmsbuild commented Aug 28, 2015

cmsbuild commented Aug 28, 2015

danduggan commented Aug 28, 2015

slava77 commented Aug 28, 2015

cmsbuild commented Aug 28, 2015

davidlange6 commented Sep 4, 2015

migrate RPCPointProducer to a global::EDProducer (75x) #10935

migrate RPCPointProducer to a global::EDProducer (75x) #10935

Conversation

fwyzard commented Aug 25, 2015

fwyzard commented Aug 25, 2015

cmsbuild commented Aug 25, 2015

fwyzard commented Aug 25, 2015

fwyzard Aug 25, 2015

Choose a reason for hiding this comment

cmsbuild commented Aug 25, 2015

cmsbuild commented Aug 25, 2015

cmsbuild commented Aug 25, 2015

fwyzard commented Aug 25, 2015

Martin-Grunewald commented Aug 25, 2015

fwyzard commented Aug 25, 2015

cmsbuild commented Aug 28, 2015

cmsbuild commented Aug 28, 2015

cmsbuild commented Aug 28, 2015

danduggan commented Aug 28, 2015

slava77 commented Aug 28, 2015

cmsbuild commented Aug 28, 2015

davidlange6 commented Sep 4, 2015