Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multithreading fix for 74x: RPCPointProducer #11355

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 18, 2015

migrate RPCPointProducer to a global::EDProducer

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 18, 2015

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 18, 2015

tracked at #11317

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Sep 18, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_4_X.

multithreading fix for 74x: RPCPointProducer

It involves the following packages:

HLTrigger/Configuration
HLTrigger/special
RecoLocalMuon/RPCRecHit
Validation/RPCRecHits

@perrotta, @cmsbuild, @cvuosalo, @fwyzard, @Martin-Grunewald, @deguio, @slava77, @broen, @danduggan can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @bellan, @jalimena, @geoff-smith, @jhgoh this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Sep 18, 2015

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 21, 2015

+1

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 21, 2015

backport #10927 / #10935 to 74x

@slava77
Copy link
Contributor

slava77 commented Sep 23, 2015

+1

for #11355 83fa2a6

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Pull request #11355 was updated. @cvuosalo, @slava77, @cmsbuild, @deguio, @danduggan, @vanbesien can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Sep 23, 2015

+1

for #11355 8b36e33

  • code changes are the same after rebase
  • jenkins tests show no differences as expected

@deguio
Copy link
Contributor

deguio commented Sep 24, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8b36e33 into cms-sw:CMSSW_7_4_X Oct 9, 2015
cmsbuild added a commit that referenced this pull request Oct 9, 2015
…ducer

multithreading fix for 74x: RPCPointProducer
@fwyzard fwyzard deleted the multithreading_74x_RPCPointProducer branch October 10, 2015 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants