Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of #11195 #11196

Merged
merged 9 commits into from
Nov 4, 2015
Merged

Backport of #11195 #11196

merged 9 commits into from
Nov 4, 2015

Conversation

usarica
Copy link
Contributor

@usarica usarica commented Sep 9, 2015

No description provided.

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Sep 9, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

A new Pull Request was created by @usarica (Ulascan Sarica) for CMSSW_7_5_X.

Backport of #11195

It involves the following packages:

Alignment/OfflineValidation
MuonAnalysis/MomentumScaleCalibration

@diguida, @cerminar, @monttj, @cmsbuild, @vadler, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @frmeier, @argiro, @bellan, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Sep 9, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

+1
Tested at: 26ada9e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11196/7975/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11196/7975/summary.html

@emiglior emiglior mentioned this pull request Sep 10, 2015
Closed
@usarica
Copy link
Contributor Author

usarica commented Sep 10, 2015

The last commit titled "Compatibility with #10477" is supposed to fix an error from the python config file when running a job. The error was due to the deletion of some of the old models in PR #10477. No errors are seen with this version yet.

@cmsbuild
Copy link
Contributor

Pull request #11196 was updated. @diguida, @cerminar, @monttj, @cmsbuild, @vadler, @mmusich can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Sep 30, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 7cdf2c6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11196/8524/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11196/8524/summary.html

@hroskes hroskes mentioned this pull request Oct 15, 2015
Merged
@diguida
Copy link
Contributor

diguida commented Oct 30, 2015

-1
superseded by #11829

@davidlange6 davidlange6 merged commit 7cdf2c6 into cms-sw:CMSSW_7_5_X Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-rejected analysis-pending comparison-available orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@usarica @cmsbuild @mmusich @diguida @davidlange6 @hroskes