Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for GEN infos in 74X or later #10477

Merged
merged 4 commits into from
Sep 3, 2015

Conversation

emiglior
Copy link
Contributor

This PR superseeds #10071.
In addition to the previous changes it includes the first round of modifications to fill properly the GEN level infos from pythia8 and NLO Monte Carlo generators.
RECO is not affected.
@maralxplus, @mabarrio This can be of interest for you as well as it affects the format of the trees created by MuScleFit as it includes an event weight useful for NLO MC,

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @emiglior (Ernesto Migliore) for CMSSW_7_4_X.

Update for GEN infos in 74X or later

It involves the following packages:

MuonAnalysis/MomentumScaleCalibration

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@bellan, @mmusich, @frmeier, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

what is the 76x and 75x version of this pr?

@emiglior
Copy link
Contributor Author

@davidlange6 The PR for 75x is #10477
I have not yet prepared the PR for 76x

@monttj
Copy link
Contributor

monttj commented Aug 3, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2015

@monttj
Copy link
Contributor

monttj commented Aug 6, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 3, 2015
Update for GEN infos in 74X or later
@cmsbuild cmsbuild merged commit fcd7ae9 into cms-sw:CMSSW_7_4_X Sep 3, 2015
usarica added a commit to usarica/cmssw that referenced this pull request Sep 10, 2015
usarica added a commit to usarica/cmssw that referenced this pull request Sep 10, 2015
usarica added a commit to usarica/cmssw that referenced this pull request Sep 10, 2015
ghellwig pushed a commit to gregor-mittag/cmssw that referenced this pull request Mar 10, 2016
ghellwig pushed a commit to gregor-mittag/cmssw that referenced this pull request Mar 11, 2016
@emiglior emiglior deleted the changes_pythia8_74X branch May 31, 2016 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants