-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
800 me0 segment time pr #12383
800 me0 segment time pr #12383
Changes from 10 commits
320eea0
bb0028e
0dd11c5
917e6dd
c9a4296
f6e6890
bf39803
59efe0d
d8eea10
48ae8e9
8f2efdc
d2f47c5
aa1d244
b57aefc
b0dfb6b
7036766
1d78602
5190a53
d69105b
1912054
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,6 +48,7 @@ class ME0RecHitBaseAlgo { | |
LocalPoint& Point, | ||
LocalError& error) const = 0; | ||
|
||
bool recOnlyMuons; | ||
}; | ||
#endif | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,9 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
me0RecHits = cms.EDProducer("ME0RecHitProducer", | ||
recAlgoConfig = cms.PSet(), | ||
recAlgoConfig = cms.PSet( | ||
recOnlyMuons = cms.bool(False), | ||
), | ||
recAlgo = cms.string('ME0RecHitStandardAlgo'), | ||
me0DigiLabel = cms.InputTag("simMuonME0Digis"), | ||
) |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,8 +13,8 @@ | |
#include "DataFormats/GEMDigi/interface/ME0DigiPreRecoCollection.h" | ||
#include "FWCore/ParameterSet/interface/ParameterSet.h" | ||
|
||
|
||
ME0RecHitBaseAlgo::ME0RecHitBaseAlgo(const edm::ParameterSet& config) { | ||
recOnlyMuons = config.getParameter<bool>("recOnlyMuons"); | ||
} | ||
|
||
ME0RecHitBaseAlgo::~ME0RecHitBaseAlgo(){} | ||
|
@@ -33,12 +33,9 @@ const ME0DigiPreRecoCollection::Range& digiRange){ | |
// Call the compute method | ||
bool OK = this->compute(*digi, point, tmpErr); | ||
if (!OK) continue; | ||
|
||
if (std::abs(digi->pdgid()) == 13) { | ||
ME0RecHit* recHit = new ME0RecHit(me0Id,digi->tof(),point,tmpErr); | ||
result.push_back(recHit); | ||
} | ||
|
||
if (recOnlyMuons && std::abs(digi->pdgid()) != 13) continue; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we should not fold MC-truth dependence in RECO algorithms. @pietverwilligen please comment if you can make this update on the time scale before pre3 (Nov 30). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi Slava We prefer to fold in MC -truth for now, to make the performance studies. I ll present our ideas in tomorrows RECO meeting. I understand there are good reasons not to include it, but I would like to discuss this in person. |
||
ME0RecHit* recHit = new ME0RecHit(me0Id,digi->tof(),point,tmpErr); | ||
result.push_back(recHit); | ||
} | ||
return result; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one should have been removed as well.
(an exposed public data member by itself is not good)