ZDC unpacker update URGENT #12544

BetterWang · 2015-11-23T15:54:10Z

[+] update working on compact FEDs readout

cmsbuild · 2015-11-23T15:56:14Z

A new Pull Request was created by @BetterWang (Quan Wang) for CMSSW_7_5_X.

It involves the following packages:

EventFilter/CastorRawToDigi

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

+1|approve[d]|sign[ed]: L1/L2's to approve it
-1|reject[ed]: L1/L2's to reject it
assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
hold: L1/all L2's/release manager to mark it as on hold
unhold: L1/user who put this PR on hold
merge: L1/release managers to merge this request
[@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
[@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

BetterWang · 2015-11-23T16:28:46Z

Hi, @davidlange6 @slava77 @Degano @smuzaffar , can anyone of you trigger the test?
This is an urgent PR to fix the ZDC unpacker needed for the heavy ion run.
Thanks,

slava77 · 2015-11-23T16:46:10Z

@BetterWang please describe the impact of the changes, including why the old one doesn't work and also provide some information showing that this update fixes particular ptoblems.

The last iteration was told to be well debugged and now we get a 500 lines worth of bugfixes.
This doesn't quite make sense.

slava77 · 2015-11-23T16:46:28Z

@cmsbuild please test

cmsbuild · 2015-11-23T16:51:19Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9903/console

BetterWang · 2015-11-23T16:58:55Z

Dear @slava77 , the last update was done based on the old FED format from 2011 PbPb run, which has been updated since then.
Now, this unpacker works fine with the new data format. However, it doesn't handle the old data.
The old data will still be handled by Hcal unpacker.
Now, I have a question. How do we make the zdcreco picking up the new label "castorDigis" instead of the old "hcalDigis", for data taking?
I haven't change any labels since it will probably cause missing label error in the matrix.
If you prefer, we can talk on skype or phone. I sent you an email just now.
Thanks,

slava77 · 2015-11-23T17:10:19Z

EventFilter/CastorRawToDigi/plugins/CastorRawToDigi.cc

@@ -21,7 +21,7 @@ using namespace std;
 CastorRawToDigi::CastorRawToDigi(edm::ParameterSet const& conf):
  dataTag_(conf.getParameter<edm::InputTag>("InputLabel")),
  unpacker_(conf.getParameter<int>("CastorFirstFED"),conf.getParameter<int>("firstSample"),conf.getParameter<int>("lastSample")),
-  zdcunpacker_(conf.getParameter<int>("ZDCFirstFED"),conf.getParameter<int>("firstSample"),conf.getParameter<int>("lastSample")),
+  zdcunpacker_(conf.getParameter<int>("CastorFirstFED"),conf.getParameter<int>("firstSample"),conf.getParameter<int>("lastSample")),


Is this correct?
it looks like the variable is actually not used (but if it would be used, it seems like the parameter would be wrong)

It is used as sourceIdOffset_:
https://github.com/BetterWang/cmssw/blob/ZDCunpacker_update/EventFilter/CastorRawToDigi/src/ZdcUnpacker.cc#L84
This is because the FED index is with respect to the first FED number.
In this case, the actual ZDC FED is 693. When referred in the ElectronicId, the uccid=693-690=3, where 690 is the FED number of the first Castor FED.

is it really used?
I don't see it anywhere in https://github.com/cms-sw/cmssw/blob/CMSSW_7_5_7/EventFilter/CastorRawToDigi/src/ZdcUnpacker.cc

It is the first argument in the ZdcUnpacker ctor.

yes, I know that, but the data member set by this argument is not used anywhere in ZdcUnpacker.cc

BetterWang · 2015-11-23T17:57:50Z

Hi all, you can find the slides at
https://www.dropbox.com/s/jpb9tlf2sqta5ju/11-23-15_ZDCunpacker.pdf?dl=0
Thanks,

cmsbuild · 2015-11-23T18:36:15Z

Pull request #12544 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again.

slava77 · 2015-11-23T18:39:01Z

@cmsbuild please test

cmsbuild · 2015-11-23T18:41:13Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9905/console

cmsbuild · 2015-11-23T18:51:15Z

Pull request #12544 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again.

slava77 · 2015-11-23T18:57:54Z

RecoHI/HiEvtPlaneAlgos/python/RecoHiEvtPlane_EventContent_cff.py

@@ -10,8 +10,7 @@

 RecoHiEvtPlaneAOD = cms.PSet(
    outputCommands = cms.untracked.vstring('keep recoEvtPlanes_hiEvtPlane_*_*',
-                                           'keep ZDCRecHitsSorted_zdcreco_*_*',


why did you drop the hits?
the keep statement should be here (despite the fact that currently these hits don't make much sense for run2 data/data unpacked into castorDigis)

Ok, putting it back.

cmsbuild · 2015-11-23T19:06:15Z

Pull request #12544 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again.

slava77 · 2015-11-23T19:14:42Z

@cmsbuild please test
[the third time might do it]

cmsbuild · 2015-11-23T19:16:13Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9906/console

cmsbuild · 2015-11-23T20:38:33Z

+1
Tested at: 75fd713
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12544/9906/summary.html

cmsbuild · 2015-11-23T20:41:49Z

-1
Tested at: 4affe83
The relvals timed out after 2 hours.

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12544/9903/summary.html

cmsbuild · 2015-11-23T21:50:22Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12544/9906/summary.html

slava77 · 2015-11-23T22:44:45Z

@smuzaffar @Degano
please check the logic in the bot for error (tests-rejected assignment): the failed test was for an older commit, while the latest commit is OK. So, technically, the label should be "tests-approved" corresponding to 75fd713

…75fd713-fixHIAOD ZDC unpacker update (as #12544 but also keep old zdc digis in HI AOD)

smuzaffar · 2015-11-24T08:36:57Z

@slava77, I will update cms-bot to also take account the latest commit hash

BetterWang added 3 commits November 23, 2015 16:47

[+] update working on compact FEDs readout

93f0e70

[-] debug output

13897a9

[-] unused

4affe83

cmsbuild added this to the Next CMSSW_7_5_X milestone Nov 23, 2015

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending comparison-pending labels Nov 23, 2015

cmsbuild added tests-started and removed tests-pending labels Nov 23, 2015

slava77 reviewed Nov 23, 2015
View reviewed changes

[!] namespace

499b6bb

cmsbuild added tests-pending and removed tests-started labels Nov 23, 2015

cmsbuild added tests-started and removed tests-pending labels Nov 23, 2015

[!] update AOD data content.

5c6666b

cmsbuild added tests-pending and removed tests-started labels Nov 23, 2015

slava77 reviewed Nov 23, 2015
View reviewed changes

[+] put back the hits

75fd713

cmsbuild added tests-started and removed tests-pending labels Nov 23, 2015

cmsbuild added tests-approved and removed tests-started labels Nov 23, 2015

cmsbuild added tests-rejected and removed tests-approved labels Nov 23, 2015

cmsbuild added comparison-available and removed comparison-pending labels Nov 23, 2015

slava77 mentioned this pull request Nov 24, 2015

ZDC unpacker update (as #12544 but also keep old zdc digis in HI AOD) #12549

Merged

cmsbuild merged commit 75fd713 into cms-sw:CMSSW_7_5_X Nov 24, 2015

cmsbuild added a commit that referenced this pull request Nov 24, 2015

Merge pull request #12549 from slava77/CMSSW_7_5_7/sign637/pull12544-…

c45c9dc

…75fd713-fixHIAOD ZDC unpacker update (as #12544 but also keep old zdc digis in HI AOD)

cmsbuild added tests-approved and removed tests-rejected labels Nov 24, 2015

This was referenced Nov 25, 2015

Quick fix to account for recent updates of castor and zdc unpackers #12570

Merged

Cleanup and update to stay in sync with modifications done in 75X #12620

Closed

Cleanup and update to stay in sync with modifications done in 75X #12621

Merged

BetterWang deleted the ZDCunpacker_update branch October 30, 2018 14:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ZDC unpacker update URGENT #12544

ZDC unpacker update URGENT #12544

BetterWang commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

BetterWang commented Nov 23, 2015

slava77 commented Nov 23, 2015

slava77 commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

BetterWang commented Nov 23, 2015

slava77 Nov 23, 2015

BetterWang Nov 23, 2015

slava77 Nov 23, 2015

BetterWang Nov 23, 2015

slava77 Nov 23, 2015

BetterWang commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

slava77 commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

slava77 Nov 23, 2015

BetterWang Nov 23, 2015

cmsbuild commented Nov 23, 2015

slava77 commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

slava77 commented Nov 23, 2015

smuzaffar commented Nov 24, 2015

ZDC unpacker update URGENT #12544

ZDC unpacker update URGENT #12544

Conversation

BetterWang commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

BetterWang commented Nov 23, 2015

slava77 commented Nov 23, 2015

slava77 commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

BetterWang commented Nov 23, 2015

slava77 Nov 23, 2015

Choose a reason for hiding this comment

BetterWang Nov 23, 2015

Choose a reason for hiding this comment

slava77 Nov 23, 2015

Choose a reason for hiding this comment

BetterWang Nov 23, 2015

Choose a reason for hiding this comment

slava77 Nov 23, 2015

Choose a reason for hiding this comment

BetterWang commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

slava77 commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

slava77 Nov 23, 2015

Choose a reason for hiding this comment

BetterWang Nov 23, 2015

Choose a reason for hiding this comment

cmsbuild commented Nov 23, 2015

slava77 commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

slava77 commented Nov 23, 2015

smuzaffar commented Nov 24, 2015