Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZDC unpacker update URGENT #12544

Merged
merged 6 commits into from
Nov 24, 2015
Merged

ZDC unpacker update URGENT #12544

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
93f0e70
[+] update working on compact FEDs readout
BetterWang Nov 23, 2015
13897a9
[-] debug output
BetterWang Nov 23, 2015
4affe83
[-] unused
BetterWang Nov 23, 2015
499b6bb
[!] namespace
BetterWang Nov 23, 2015
5c6666b
[!] update AOD data content.
BetterWang Nov 23, 2015
75fd713
[+] put back the hits
BetterWang Nov 23, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion EventFilter/CastorRawToDigi/plugins/CastorRawToDigi.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ using namespace std;
CastorRawToDigi::CastorRawToDigi(edm::ParameterSet const& conf):
dataTag_(conf.getParameter<edm::InputTag>("InputLabel")),
unpacker_(conf.getParameter<int>("CastorFirstFED"),conf.getParameter<int>("firstSample"),conf.getParameter<int>("lastSample")),
zdcunpacker_(conf.getParameter<int>("ZDCFirstFED"),conf.getParameter<int>("firstSample"),conf.getParameter<int>("lastSample")),
zdcunpacker_(conf.getParameter<int>("CastorFirstFED"),conf.getParameter<int>("firstSample"),conf.getParameter<int>("lastSample")),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct?
it looks like the variable is actually not used (but if it would be used, it seems like the parameter would be wrong)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used as sourceIdOffset_:
https://github.com/BetterWang/cmssw/blob/ZDCunpacker_update/EventFilter/CastorRawToDigi/src/ZdcUnpacker.cc#L84
This is because the FED index is with respect to the first FED number.
In this case, the actual ZDC FED is 693. When referred in the ElectronicId, the uccid=693-690=3, where 690 is the FED number of the first Castor FED.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it really used?
I don't see it anywhere in https://github.com/cms-sw/cmssw/blob/CMSSW_7_5_7/EventFilter/CastorRawToDigi/src/ZdcUnpacker.cc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the first argument in the ZdcUnpacker ctor.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I know that, but the data member set by this argument is not used anywhere in ZdcUnpacker.cc

ctdcunpacker_(conf.getParameter<int>("CastorFirstFED"),conf.getParameter<int>("firstSample"),conf.getParameter<int>("lastSample")),
filter_(conf.getParameter<bool>("FilterDataQuality"),conf.getParameter<bool>("FilterDataQuality"),false,0,0,-1),
fedUnpackList_(conf.getUntrackedParameter<std::vector<int> >("FEDs",std::vector<int>())),
Expand Down