Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTDQM reading TwinMux. #13123

Merged
merged 3 commits into from Feb 12, 2016
Merged

Conversation

jfernan2
Copy link
Contributor

For MWGR-2.

dttfDigis still reading DCC in Configuration/S…andardSequences/python/RawToDigi_cff.py as process dttfDigis, change in future to dttm7Digis.

We will need a backport of these changes to 7_5_7_pre2 in order to use it in MWGR-1

…tandardSequences/python/RawToDigi_cff.py as process dttfDigis, change in future to dttm7Digis
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jfernan2 for CMSSW_8_0_X.

It involves the following packages:

DQM/DTMonitorClient
DQM/DTMonitorModule
DQM/Integration

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @batinkov this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@deguio
Copy link
Contributor

deguio commented Feb 1, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10877/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2016

@deguio
Copy link
Contributor

deguio commented Feb 1, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

looks like this change assumes #13058 goes in. @mulhearn is that nearly ready?

@jfernan2
Copy link
Contributor Author

jfernan2 commented Feb 1, 2016

I confirm this PR needs #13058, sorry I should have warned it at the beginning.
Thanks

@mulhearn
Copy link
Contributor

mulhearn commented Feb 1, 2016

Well #13058 will have to be recast into the L1TXRawToDigi package. Won't be ready until much later tonight I am afraid...

@jfernan2
Copy link
Contributor Author

jfernan2 commented Feb 1, 2016

Does that actually mean another folder/package for #13058 code? If so, this PR will need an update to comply with the change.

@mulhearn
Copy link
Contributor

mulhearn commented Feb 1, 2016

Yes, sorry, 'fraid so.

@jfernan2
Copy link
Contributor Author

jfernan2 commented Feb 1, 2016

No problem. Do we know the name of the package so that I can anticipate and update the PR now in order to avoid further delays from my side? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11099/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2016

-1
Tested at: c589b53
I found an error when building:

>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-09-1100/src/DQM/DTMonitorModule/plugins/plugins.cc 
>> Building shared library tmp/slc6_amd64_gcc493/src/DQMServices/Core/src/DQMServicesCore/libDQMServicesCore.so
@@@@ Checking for missing symbols was SKIPPED due to NO_LIB_CHECKING flag in BuildFile: libUtilitiesStaticAnalyzers.so
>> Building binary MakeDeanHTML
>> Building binary DQMCollector
c++: error: tmp/slc6_amd64_gcc493/src/DQMServices/Core/src/DQMServicesCore/DQMService.o: No such file or directory
gmake: **\* [tmp/slc6_amd64_gcc493/src/DQMServices/Core/src/DQMServicesCore/libDQMServicesCore.so] Error 1
Copying tmp/slc6_amd64_gcc493/src/DQMServices/Diagnostic/bin/MakeDeanHTML/MakeDeanHTML to productstore area:
Copying tmp/slc6_amd64_gcc493/src/DQMServices/Core/bin/DQMCollector/DQMCollector to productstore area:
Leaving library rule at DQMServices/Core
>> Building shared library tmp/slc6_amd64_gcc493/src/Utilities/StaticAnalyzers/src/UtilitiesStaticAnalyzers/libUtilitiesStaticAnalyzers.so


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13123/11099/summary.html

@jfernan2
Copy link
Contributor Author

jfernan2 commented Feb 9, 2016

The error seems to be related to other DQM part but not exactly to the code I have committed. I have tried the code in the same release CMSSW_8_0_X_2016-02-09-1100 as the one tested and I get no such building error, how can I debug further? Thanks in advance.

@jfernan2
Copy link
Contributor Author

@deguio any hint about how to debug this? See my previous post. Thanks in advance.

@deguio
Copy link
Contributor

deguio commented Feb 10, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11130/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@jfernan2
Copy link
Contributor Author

Dear managers, DT group would like to have this PR merged for MWGR-2, which will use CMSSW80X in order to avoid private DQMs. Is there any additional showstopper?
Thanks in advance.

@deguio
Copy link
Contributor

deguio commented Feb 12, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Feb 12, 2016
@davidlange6 davidlange6 merged commit 3d03721 into cms-sw:CMSSW_8_0_X Feb 12, 2016
@deguio deguio mentioned this pull request Feb 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants