Pr l1tx unpackers #13165
Pr l1tx unpackers #13165
Conversation
|
A new Pull Request was created by @mulhearn for CMSSW_8_0_X. It involves the following packages: EventFilter/L1TXRawToDigi The following packages do not have a category, yet: EventFilter/L1TXRawToDigi @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
+1 |
|
@davidlange6 this one is harmless (not used anywhere yet) and compiles. Can you merge this one? |
| if(cPhi == 0) cPhi = 72; | ||
| else if(cPhi == -1) cPhi = 71; | ||
| else if(cPhi < -1) { | ||
| std::cerr << "L1TCaloLayer1RawToDigi: Major error in makeECalTPGs" << std::endl; |
|
@jpazzini if you would like to make these fixes, be my guest. You are a cms-l1t-offline member so you can push directly back to this branch. Use CMSSW_8_0_0_pre5 so you won't have to bother with rebasing... Let me know if you have questions. Otherwise, I'll get to this eventually. |
mulhearn
force-pushed
the
pr-l1tx-unpackers
branch
from
4496438
to
c4243fe
Compare
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #13165 was updated. @cmsbuild, @davidlange6 can you please check and sign again. |
mulhearn
force-pushed
the
pr-l1tx-unpackers
branch
from
c4243fe
to
d2ede48
Compare
|
Pull request #13165 was updated. @cmsbuild, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
@davidlange6 please don't forget this guy, which is easily missed since no l1 sign off needed (new package). |
|
@mulhearn @davidlange6 - spotted a bug on the TwinMux unpacker after the MWGR. I have the bug-fix ready to be pushed. How do I behave? Do we need to make a new PR, or should we re-open this one? |
|
@jpazzini: this PR has been merged already, please make a new one |
|
@deguio - with respect to the "original" PR, the TwinMux unpacker changed its name when it was requested to merge it into this branch. I thought this decision was taken together by DT and L1. @davidlange6 might know more about this. |
Contains the unpackers for the CaloLayer1 and TwinMux subdetectors.