updating TrackerGeometry in Geometry/TrackerGeometryBuilder to accom…

[suchandradutta]

updating TrackerGeometry in Geometry/TrackerGeometryBuilder to accommodate the final naming scheme for Phase2 Pixel detectors and corresponding update in Phase2Digitizer

[cmsbuild]

A new Pull Request was created by @suchandradutta (Suchandra Dutta) for CMSSW_8_1_X.

It involves the following packages:

Geometry/TrackerGeometryBuilder
SimTracker/SiPhase2Digitizer

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @cerati, @threus, @dgulhan, @venturia this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11864/console

[boudoul]

Dear @suchandradutta and @ianna
Could you apply also this change in Phase2TrackerDigitizer.cc (line 108)

Update
iSetup.get().get(tTopoHand);

by

iSetup.get().get(tTopoHand);

it's needed to make it work in 8X
Thanks
Gaelle

[boudoul]

troubles with the formatting in github : reformulating here my previous comment

changes
IdealGeometryRecord
by
TrackerTopologyRcd

in line108

[cmsbuild]

Pull request #13706 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again.

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11867/console

[cmsbuild]

+1
Tested at: b4127b2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13706/11864/summary.html

[cmsbuild]

+1
Tested at: be33720
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13706/11867/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13706/11864/summary.html

[ianna]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13706/11867/summary.html

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1