Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "updating TrackerGeometry in Geometry/TrackerGeometryBuilder to accom…" #13755

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Mar 17, 2016

Reverts #13706

The PR I am reverting is using new names for the phase2 digitizer which are not yet defined in the Geometry (for Tracker Phase2), therefore I'm reverting this PR as long as the new names in the Tracker Phase2 Geometry are not defined,

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @boudoul (boudoul) for CMSSW_8_1_X.

It involves the following packages:

Geometry/TrackerGeometryBuilder
SimTracker/SiPhase2Digitizer

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @cerati, @threus, @dgulhan, @venturia this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@civanch
Copy link
Contributor

civanch commented Mar 18, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11963/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Mar 18, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Mar 19, 2016
…Digitizer

Revert "updating  TrackerGeometry in Geometry/TrackerGeometryBuilder to accom…"
@davidlange6 davidlange6 merged commit 2ae0f35 into cms-sw:CMSSW_8_1_X Mar 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants