Fix Puppi MET and smearing MET correction, add central test for the MET tool #13954

mmarionncern · 2016-04-06T11:39:05Z

This PR fixes only configuration : the computation of the puppiMET in the miniAOD production, now using the proper jet energy corrections for the puppiMET and a small inconsistency in the MET smearing correction have been also added.
A central test for the MET tool has been added, in order to avoid conflicts such as the one seen with the update of the PAT names few weeks ago.
Few internal variable names were also modified.

The miniAOD to miniAOD MET reprocessing example test file has been updated and a test file for the MET production from AOD has been added.

Packages impacted by this PR :

PhysicsTools/PatAlgos
PhysicsTools/PatUtils

Changes :

puppiMET will change due to the modification of the jet energy corrections used
the smeared T1 PFMET is changing, no other change expected for the slimmedMET content
no modification of the CPU/memory performances for the miniAOD production sequence
fix MET unclustered uncertainty bug
fix jet smearing bug

cmsbuild · 2016-04-06T11:39:28Z

A new Pull Request was created by @mmarionncern for CMSSW_8_0_X.

It involves the following packages:

PhysicsTools/PatAlgos
PhysicsTools/PatUtils

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @rappoccio, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

slava77 · 2016-04-06T12:47:53Z

@cmsbuild please test
... this is expected to go to the first re-miniAOD version, unlikely sooner.

cmsbuild · 2016-04-06T12:48:15Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12204/console

mmarionncern · 2016-04-06T12:50:27Z

@slava77 those fixes are quite minor ones, no problem of not having them super-soon

cmsbuild · 2016-04-06T13:43:13Z

-1
Tested at: d6edab2
When I ran the RelVals I found an error in the following worklfows:
50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
----- Begin Fatal Exception 06-Apr-2016 15:22:37 CEST-----------------------
An exception of category 'InvalidInput' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'validation_step1'
   [2] Calling event method for module METTester/'pfPuppiMetAnalyzerMiniAOD'
   [3] Calling produce method for unscheduled module PATMETSlimmer/'slimmedMETsPuppi'
   [4] Calling produce method for unscheduled module CorrectedPATMETProducer/'patPFMetT1JetEnUpPuppi'
   [5] Calling produce method for unscheduled module ShiftedParticleMETcorrInputProducer/'shiftedPatMETCorrJetEnUpPuppi'
   [6] Calling produce method for unscheduled module ShiftedPATJetProducer/'shiftedPatJetEnUpPuppi'
Exception Message:
 cannot find key 9 in the JEC payload, this usually means you have to change the global tag
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13954/12204/summary.html

gpetruc · 2016-04-06T14:07:15Z

could we split off the part that affects miniAOD production from the one that does not?
and understand whether the first part is something small enough that could go in v2 or not?

I don't like the idea of producing miniAOD v2 mainly to put in some new JECs, but do that with a release that applies them wrongly.

@arizzi

mmarionncern · 2016-04-06T16:18:21Z

The matrix test fails due to the use of the GT pointed by " auto:run2_mc_50ns" which does not contains the Puppi JEC. I don't know what is the proper action to take : should they be added to that GT or should the _50ns be removed from the GT pointer (the matrix test works with auto:run2_mc)?

mmarionncern · 2016-04-06T16:22:34Z

@gpetruc @arizzi

The changes affecting the miniAOD production is half of the PR in term of changes :
-> puppi JEC corrections for puppiMET
-> MET smearing correction (minor correction and not needed for a new production, but still affecting it)

The other ones are just and update of the test files and a new unit test.

The separation between both is feasible, but it means I will have to split the single commit we have right now.

mmarionncern · 2016-04-07T07:50:28Z

@slava77 @mmusich

After extra investigation, the failure in the matrix test comes from the fact that Puppi JEC uncertainties (and only the uncertainties) are missing in the 50ns GT. Should we add them in the current GT or create a new one?

( @blinkseb )

mmusich · 2016-04-07T08:00:59Z

@mmarionncern, just to clarify, PUPPI JEC for 50ns do exist. Only uncertainties are not available.
As far as I can recall JETMET never provided JEC uncertainties for 50ns...
If they have suitable payload this can be included @blinkseb .
Otherwise do we still need to have the 50ns RelVals in matrix ? If yes and no palyoads for 50ns are available one can put a set of dummy ones.

slava77 · 2016-04-07T10:03:02Z

On 4/7/16 4:01 AM, Marco Musich wrote:

@mmarionncern https://github.com/mmarionncern, just to clarify, PUPPI
JEC for 50ns do exist. Only uncertainties are not available.
As far as I can recall JETMET never provided JEC uncertainties for 50ns...
If they have suitable payload this can be included @blinkseb
https://github.com/blinkseb .
Otherwise do we still need to have the 50ns RelVals in matrix ? If yes
and no palyoads for 50ns are available one can put a set of dummy ones.

To the first order, I'd supply the same as for 25ns.
Dummy with random numbers (like 1 or 0) may be worse.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#13954 (comment)

mmusich · 2016-04-07T10:24:52Z

From a previous thread with @blinkseb:

"concerning the issue with uncertainties, it seems the database we use for 50ns does not contains the uncertainties for all the jets collection, but only for AK4PFchs. I'll update this database so that if we need another GT for 2015 the 50ns uncertainties are included for all jet collections."
I think the time has come :)
thanks,

Marco

blinkseb · 2016-04-07T11:36:40Z

Indeed ;) It's fairly easy to do, but should I request the creation of a new 50ns GT? Or maybe the new feature of creating private GT can be useful in this case?

mmusich · 2016-04-07T11:39:18Z

@blinkseb go ahead and create the self-GT for this purpose! once we've seen this PR works we'll update queues and autoCond. thanks

blinkseb · 2016-04-07T12:29:25Z

Self-GT created: 80X_mcRun2_startup_Candidate_2016_04_07_12_27_27. I updated the JEC version from V5 to V6 (Summer15_50nsV6). Only changes wrt to V5 is the addition of uncertainties for all the jet algorithm.

Is there something else I need to do on my side?

mmusich · 2016-04-07T12:30:28Z

@blinkseb no, thanks! @mmarionncern needs to change his version of autoCond.py in this PR and re-run the tests

cmsbuild · 2016-04-13T11:22:33Z

Pull request #13954 was updated. @cvuosalo, @cerminar, @cmsbuild, @franzoni, @slava77, @mmusich, @davidlange6 can you please check and sign again.

cmsbuild · 2016-04-13T14:13:37Z

Pull request #13954 was updated. @cvuosalo, @cerminar, @cmsbuild, @franzoni, @slava77, @mmusich, @davidlange6 can you please check and sign again.

cvuosalo · 2016-04-13T22:49:17Z

@cmsbuild please test

cmsbuild · 2016-04-13T22:49:54Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12356/console

cmsbuild · 2016-04-14T01:28:14Z

+1
Tested at: fc8b57c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13954/12356/summary.html

cmsbuild · 2016-04-14T02:27:21Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13954/12356/summary.html

cvuosalo · 2016-04-15T17:05:11Z

+1

For #13954 fc8b57c

Fixing PUPPI MET in Mini-AOD.

The code changes are satisfactory. Jenkins tests against baseline CMSSW_8_0_X_2016-04-12-2300 show only the expected differences in PUPPI MET. An extended test of workflow 25202.0_TTbar_13 with 70 events against baseline CMSSW_8_0_X_2016-04-07-2300 also shows only the expected small differences from the MET fix. RECO event content does not change, and Mini-AOD event content changes only very slightly:

   or, B         new, B      delta, B   delta, %   deltaJ, %    branch 
-----------------------------------------------------------------
    948.4 ->       950.5          2      0.2   0.00     patMETs_slimmedMETsNoHF__RECO.
-------------------------------------------------------------
    79885 ->       79888          3             0.0     ALL BRANCHES

mmusich · 2016-04-15T17:07:18Z

+1

slava77 · 2016-04-19T15:11:47Z

It looks like this PR broke 50 ns run2 and run 1 workflows with PAT.
Revert or fix?

mmusich · 2016-04-19T15:32:22Z

@slava77 are you referring to this:

----- Begin Fatal Exception 19-Apr-2016 06:59:27 CEST-----------------------
An exception of category 'InvalidInput' occurred while
   [0] Processing run: 172802 lumi: 41 event: 33766250
   [1] Running path 'dqmofflineOnPAT_1_step'
   [2] Calling event method for module METAnalyzer/'pfPuppiMetDQMAnalyzerMiniAOD'
   [3] Calling produce method for unscheduled module PATMETSlimmer/'slimmedMETsPuppi'
   [4] Calling produce method for unscheduled module CorrectedPATMETProducer/'patPFMetT1JetEnUpPuppi'
   [5] Calling produce method for unscheduled module ShiftedParticleMETcorrInputProducer/'shiftedPatMETCorrJetEnUpPuppi'
   [6] Calling produce method for unscheduled module ShiftedPATJetProducer/'shiftedPatJetEnUpPuppi'
Exception Message:
 cannot find key 9 in the JEC payload, this usually means you have to change the global tag

we need the 50ns uncertainty propagated everywhere we need it (i.e. both run2 50ns data and run1 data)

mmusich · 2016-04-19T15:34:10Z

@blinkseb do you think it would be feasible to get the 50ns IOVs of Run2 data and Run1 data fixed adding the uncertainties?

blinkseb · 2016-04-19T15:42:26Z

@mmusich Yes sure, I'm doing it right now. For Run1 data, is there an issue using for example CMSSW 8.0.X to create the database?

mmusich · 2016-04-19T15:51:39Z

@blinkseb we are using the 80X_dataRun2_v* tags to cover also run1 data in autoCond. Right now looking for example at what we have proposed in GT for a random label:

https://cms-conddb.cern.ch/cmsDbBrowser/list/Prod/tags/JetCorrectorParametersCollection_Fall15_V2_DATA_AK4PF

I see:

1   2016-02-21 15:34:16,000000  bb5376a0d75485827869da3f4043f819e5f4e5a4
253000  2016-02-21 15:34:16,000000  a9c3d63fff11cac50220489fb9e11180614a835e
254833  2016-02-21 15:34:16,000000  bb5376a0d75485827869da3f4043f819e5f4e5a4
254834  2016-02-21 15:34:16,000000  a9c3d63fff11cac50220489fb9e11180614a835e
254981  2016-02-21 15:34:16,000000  bb5376a0d75485827869da3f4043f819e5f4e5a4
255032  2016-02-21 15:34:16,000000  a9c3d63fff11cac50220489fb9e11180614a835e

we need therefore a new payload for the IOV [1-25300] and also for the 50ns ones covering run2 data (I think you have the correct boundaries)

blinkseb · 2016-04-19T15:54:52Z

Ok great, thanks a lot! Should I create a self-GT for this one, or request a new GT as usual via the hypernews?

mmusich · 2016-04-19T15:55:42Z

please queue them and announce when done. I'll cut the new GT and make the PR, from the ORP today I understand it's kind of urgent. Thanks,
Marco

blinkseb · 2016-04-19T16:17:28Z

@mmusich Announcement done: https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2300.html

I hope it'll be ok!

mmusich · 2016-04-19T16:48:59Z

@blinkseb thanks a lot: #14152
should get us rid of the failures.

cmsbuild added this to the Next CMSSW_8_0_X milestone Apr 6, 2016

cmsbuild added reconstruction-pending analysis-pending pending-signatures tests-pending orp-pending comparison-pending labels Apr 6, 2016

mmarionncern mentioned this pull request Apr 6, 2016

Fix Puppi MET and smearing MET correction, add central test for the MET tool (81X) #13955

Merged

cmsbuild added tests-started and removed tests-pending labels Apr 6, 2016

cmsbuild added tests-rejected and removed tests-started labels Apr 6, 2016

cmsbuild added alca-pending and removed tests-rejected labels Apr 7, 2016

simplify TFormula for the MET uncertainties

fc8b57c

cmsbuild added tests-started and removed tests-pending labels Apr 13, 2016

cmsbuild added tests-approved and removed tests-started labels Apr 14, 2016

cmsbuild added comparison-available and removed comparison-pending labels Apr 14, 2016

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Apr 15, 2016

cmsbuild added alca-approved and removed alca-pending labels Apr 15, 2016

davidlange6 merged commit e558d65 into cms-sw:CMSSW_8_0_X Apr 18, 2016

mmusich mentioned this pull request Apr 19, 2016

HLT update to L1T menu v5 incl. GT (80X) #14106

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Puppi MET and smearing MET correction, add central test for the MET tool #13954

Fix Puppi MET and smearing MET correction, add central test for the MET tool #13954

mmarionncern commented Apr 6, 2016

cmsbuild commented Apr 6, 2016

slava77 commented Apr 6, 2016

cmsbuild commented Apr 6, 2016

mmarionncern commented Apr 6, 2016

cmsbuild commented Apr 6, 2016

gpetruc commented Apr 6, 2016

mmarionncern commented Apr 6, 2016

mmarionncern commented Apr 6, 2016

mmarionncern commented Apr 7, 2016

mmusich commented Apr 7, 2016

slava77 commented Apr 7, 2016

mmusich commented Apr 7, 2016

blinkseb commented Apr 7, 2016

mmusich commented Apr 7, 2016

blinkseb commented Apr 7, 2016

mmusich commented Apr 7, 2016

cmsbuild commented Apr 13, 2016

cmsbuild commented Apr 13, 2016

cvuosalo commented Apr 13, 2016

cmsbuild commented Apr 13, 2016

cmsbuild commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

cvuosalo commented Apr 15, 2016

mmusich commented Apr 15, 2016

slava77 commented Apr 19, 2016

mmusich commented Apr 19, 2016 •

edited

mmusich commented Apr 19, 2016

blinkseb commented Apr 19, 2016

mmusich commented Apr 19, 2016 •

edited

blinkseb commented Apr 19, 2016

mmusich commented Apr 19, 2016

blinkseb commented Apr 19, 2016

mmusich commented Apr 19, 2016

Fix Puppi MET and smearing MET correction, add central test for the MET tool #13954

Fix Puppi MET and smearing MET correction, add central test for the MET tool #13954

Conversation

mmarionncern commented Apr 6, 2016

cmsbuild commented Apr 6, 2016

slava77 commented Apr 6, 2016

cmsbuild commented Apr 6, 2016

mmarionncern commented Apr 6, 2016

cmsbuild commented Apr 6, 2016

gpetruc commented Apr 6, 2016

mmarionncern commented Apr 6, 2016

mmarionncern commented Apr 6, 2016

mmarionncern commented Apr 7, 2016

mmusich commented Apr 7, 2016

slava77 commented Apr 7, 2016

mmusich commented Apr 7, 2016

blinkseb commented Apr 7, 2016

mmusich commented Apr 7, 2016

blinkseb commented Apr 7, 2016

mmusich commented Apr 7, 2016

cmsbuild commented Apr 13, 2016

cmsbuild commented Apr 13, 2016

cvuosalo commented Apr 13, 2016

cmsbuild commented Apr 13, 2016

cmsbuild commented Apr 14, 2016

cmsbuild commented Apr 14, 2016

cvuosalo commented Apr 15, 2016

mmusich commented Apr 15, 2016

slava77 commented Apr 19, 2016

mmusich commented Apr 19, 2016 • edited

mmusich commented Apr 19, 2016

blinkseb commented Apr 19, 2016

mmusich commented Apr 19, 2016 • edited

blinkseb commented Apr 19, 2016

mmusich commented Apr 19, 2016

blinkseb commented Apr 19, 2016

mmusich commented Apr 19, 2016

mmusich commented Apr 19, 2016 •

edited

mmusich commented Apr 19, 2016 •

edited