Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L1T Ntuple updates for l1t-tsg-v5 #14028

Closed
wants to merge 1 commit into from
Closed

L1T Ntuple updates for l1t-tsg-v5 #14028

wants to merge 1 commit into from

Conversation

mulhearn
Copy link
Contributor

This brings L1TNtuples up-to-date with l1t-tsg-v5.

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Apr 12, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mulhearn for CMSSW_8_1_X.

It involves the following packages:

L1Trigger/L1TNtuples

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mulhearn
Copy link
Contributor Author

please test

@mulhearn
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12297/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@mulhearn mulhearn mentioned this pull request Apr 12, 2016
Open
@cmsbuild
Copy link
Contributor

+1
Tested at: c2f36be
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14028/12297/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14028/12297/summary.html

davidlange6
davidlange6 reviewed Apr 12, 2016
View reviewed changes
L1Trigger/L1TNtuples/plugins/L1UpgradeTfMuonTreeProducer.cc

maxL1UpgradeTfMuon_ = iConfig.getParameter<unsigned int>("maxL1UpgradeTfMuon");

l1UpgradeBmtf = new L1Analysis::L1AnalysisL1UpgradeTfMuon();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mulhearn - you need to delete these pointers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these don't even need to be pointers in the first place... fixing.

@davidlange6
Copy link
Contributor

ping @mulhearn

@mulhearn mulhearn mentioned this pull request Apr 28, 2016
Closed
@mulhearn
Copy link
Contributor Author

mulhearn commented May 2, 2016

This one isn't urgent, but should finally get to it today or so.

@mulhearn mulhearn mentioned this pull request May 2, 2016
Merged
@mulhearn
Copy link
Contributor Author

mulhearn commented May 2, 2016

This PR has been superseded at #14319.

@mulhearn mulhearn closed this May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed l1-approved orp-pending tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mulhearn @cmsbuild @davidlange6