Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update L1TNuples to l1t-tsg-v5, and address memory management problems. #14319

Merged
merged 2 commits into from May 2, 2016

Conversation

mulhearn
Copy link
Contributor

@mulhearn mulhearn commented May 2, 2016

This brings L1TNtuples up-to-date with l1t-tsg-v5. It adds additional updates for memory management as requested by David.

This supersedes #14028.

The same branch can now be used for both 80x and 81x PRs. Past experience has taught me that force pushing such a branch to the original PR 14028 will not work nicely as one would expect, and lots of people will get unnecessary e-mail. So just making a new 81x PR.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2016

A new Pull Request was created by @mulhearn for CMSSW_8_1_X.

It involves the following packages:

L1Trigger/L1TNtuples

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mulhearn
Copy link
Contributor Author

mulhearn commented May 2, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12756/console

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2016

@mulhearn
Copy link
Contributor Author

mulhearn commented May 2, 2016

This passes our internal tests and does not change algorithm.

@mulhearn
Copy link
Contributor Author

mulhearn commented May 2, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ca7fe1d into cms-sw:CMSSW_8_1_X May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants