New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update L1TNuples to l1t-tsg-v5, and address memory management problems. #14319
Update L1TNuples to l1t-tsg-v5, and address memory management problems. #14319
Conversation
A new Pull Request was created by @mulhearn for CMSSW_8_1_X. It involves the following packages: L1Trigger/L1TNtuples @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
This passes our internal tests and does not change algorithm. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
This brings L1TNtuples up-to-date with l1t-tsg-v5. It adds additional updates for memory management as requested by David.
This supersedes #14028.
The same branch can now be used for both 80x and 81x PRs. Past experience has taught me that force pushing such a branch to the original PR 14028 will not work nicely as one would expect, and lots of people will get unnecessary e-mail. So just making a new 81x PR.