CSC Unpacker fixes for 2016 TMB/OTMB firmware updates (80X)

[barvic]

• Updated CSC unpacking code to properly recognize new OTMB/TMB firmware revisions for 2016
• Number of TMB 2013 header data bits positions are updated to match latest TMB data format revision documentation
• Reformatted number of TMB related files (added missing end of lines and etc. )
• Fixed bug in the CSCDCCExaminer to properly detect DMB CFEB1-3 FIFO Full status

If it is possible please give this update higher priority for tests and deployment as urgent patch.
The final deployment of updated TMB firmware (with new important features) depends on this code availability CMS-wide.

[cmsbuild]

A new Pull Request was created by @barvic for CMSSW_8_0_X.

It involves the following packages:

EventFilter/CSCRawToDigi

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[slava77]

@barvic
please make a PR for 81X
the policy is to integrate software in the development release first (81X)

Also, please provide some instructions to test on data with the new firmware version (IIUC, this is fixing issues that were seen already in an actual data taking run, be that local or global)

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12829/console

[barvic]

@slava77
I tested it with run 271656 ZeroBias1 data sample.
This is the run, which has new TMB firmware uploaded to whole CSC system and where "TMB Word Count" format errors were observed for all ME12, ME13 chambers and they were skipped from the unpacking because of those errors.
With the proposed fix the format errors are gone and ME12, ME13 chambers are properly unpacked.

I also tested it with tun 272011 ZeroBias1 data sample.
This one has TMB firmware downgraded on ME12, ME13 chambers (others non-ME11 chambers are still running with new TMB firmware without issues). Didn't notice any related issues.

Please see attached CSC DQM plots from the run 271656 with 'before' and 'after' the unpacker fix changes and remarks.

[cmsbuild]

+1
Tested at: e318545
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14380/12829/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14380/12829/summary.html

[slava77]

+1

for #14380 e318545

• code changes are as described, to fix data unpacking with the new TMB firmware (not installed at the moment, but needed imminently or in very near future); the same code changes as in CSC Unpacker fixes for 2016 TMB/OTMB firmware updates (81X) #14381
• jenkins tests pass and comparisons with baseline show no differences
• relying on local tests done in 810pre4 for signoff of CSC Unpacker fixes for 2016 TMB/OTMB firmware updates (81X) #14381 and, more importantly, on the plots provided by @barvic earlier in this thread

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1