Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSC Unpacker fixes for 2016 TMB/OTMB firmware updates (81X) #14381

Merged

Conversation

barvic
Copy link
Contributor

@barvic barvic commented May 4, 2016

  • Updated CSC unpacking code to properly recognize new OTMB/TMB firmware revisions for 2016
  • Number of TMB 2013 header data bits positions are updated to match latest TMB data format revision documentation
  • Reformatted number of TMB related files (added missing end of lines and etc. )
  • Fixed bug in the CSCDCCExaminer to properly detect DMB CFEB1-3 FIFO Full status

If it is possible please give this update higher priority for tests and deployment as urgent patch.
The final deployment of updated TMB firmware (with new important features) depends on this code availability CMS-wide.

Please also refer to 80X PR #14380

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2016

A new Pull Request was created by @barvic for CMSSW_8_1_X.

It involves the following packages:

EventFilter/CSCRawToDigi

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented May 4, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12831/console

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2016

@slava77
Copy link
Contributor

slava77 commented May 9, 2016

+1

for #14381 350121d

  • code changes look OK and are in line with the description
  • jenkins tests pass and comparisons with baseline show no differences (as expected for MC and for data with the old firmware in CSC TMBs)
  • local tests with the suggested run 271656 confirm observed bad behavior without this PR and show an improvement / recovery with this PR. E.g.
    minimumbias271656_csc_segoccupancy_eta_phi
    minimumbias271656_csc_upk_errors
    In chamber-specific plots there are changes only in ME1/2 and ME1/3, as expected.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1b3119e into cms-sw:CMSSW_8_1_X May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants