-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alcareco ecal trg #14684
Alcareco ecal trg #14684
Conversation
A new Pull Request was created by @shervin86 for CMSSW_8_1_X. It involves the following packages: Calibration/EcalAlCaRecoProducers @ghellwig, @franzoni, @cerminar, @fabozzi, @cmsbuild, @srimanob, @mmusich, @hengne, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 05999d6 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log1000.0 step2 runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log |
SelectEvents = cms.vstring('pathALCARECOEcalTrg'), | ||
), | ||
outputCommands = cms.untracked.vstring( | ||
'CaloTowersSorted_towerMaker_*', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shervin86 you need to include the keep
and drop
statements.
----- Begin Fatal Exception 30-May-2016 14:57:08 CEST-----------------------
An exception of category 'Configuration' occurred while
[0] Constructing the EventProcessor
[1] Constructing module: class=PoolOutputModule label='ALCARECOStreamEcalTrg'
Exception Message:
Invalid statement in configuration file
In OutputModule parameter named 'outputCommands'
Rule must specify 'keep ' or 'drop ' and also supply a pattern.
This is the invalid output configuration rule:
CaloTowersSorted_towerMaker_*
Exception thrown from ProductSelectorRules::Rule
----- End Fatal Exception -------------------------------------------------
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes.... just realized. I've fixed that and running the runTheMatrix to make sure now there are no other problems....
Shervin
On Mon, 30 May 2016, Marco Musich wrote:
Date: Mon, 30 May 2016 18:49:48 +0200
From: Marco Musich notifications@github.com
Reply-To: cms-sw/cmssw
<reply+0045c225ea74ca34bd4e55dd767cf9506c657639cb178a8f92cf000000011364312
c92a170ce03e13aca@reply.github.com>
To: cms-sw/cmssw cmssw@noreply.github.com
Cc: shervin86 shervin@cern.ch, Mention mention@noreply.github.com
Subject: Re: [cms-sw/cmssw] Alcareco ecal trg (#14684)@@ -0,0 +1,96 @@
+import FWCore.ParameterSet.Config as cms
+
+OutALCARECOEcalTrg_noDrop = cms.PSet(
put this if you have a filter
- SelectEvents = cms.untracked.PSet(
SelectEvents = cms.vstring('pathALCARECOEcalTrg'),
- ),
- outputCommands = cms.untracked.vstring(
'CaloTowersSorted_towerMaker_*',
@shervin86 you need to include the
keep
anddrop
statements.----- Begin Fatal Exception 30-May-2016 14:57:08 CEST----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=PoolOutputModule label='ALCARECOStreamEcalTrg' Exception Message: Invalid statement in configuration file In OutputModule parameter named 'outputCommands' Rule must specify 'keep ' or 'drop ' and also supply a pattern. This is the invalid output configuration rule: CaloTowersSorted_towerMaker_* Exception thrown from ProductSelectorRules::Rule ----- End Fatal Exception -------------------------------------------------
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/cms-sw/cmssw/pull/14684/files/05999d6d54d5abf13199e6f5d8e362b14111654b#r65092298
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
urra' |
+1 |
+1 |
Hello, we are experiencing failures due to this backport of EcalTrg to 80X. and worst thing, in a re-reco wf on ZeroBias: Unless you have better proposals, I think we should remove the EcalTrg path from autoAlca |
It seems so - but is it obvious why this wasn't seen in 81x relvals? (or was it just ignored there?) |
no, simply the run number probed in the RelVals was covered by the correct AlCaRecoTriggerBit. |
On 5 August 2016 at 10:23, David Lange notifications@github.com wrote:
Is the global tag the same for both releases ? .A |
@fabozzi for the specific use case of the re-reco which GT are you using? |
ok - so we just need a protection against the alca crashing just because its trigger bit doesn’t happen to be in the menu (and an update to the 81x relvals to cover the region we want to use in 80x (or vis versa..) On Aug 5, 2016, at 10:27 AM, Marco Musich <notifications@github.commailto:notifications@github.com> wrote: no, simply the run number probed in the RelVals was covered by the correct AlCaRecoTriggerBit. — |
@davidlange6 I agree |
@mmusich |
@fabozzi this explains the failures, since it's not deployed in the standard alcareco matrix we deploy at tier0 the trigger bit is not set in the Prompt GT. |
So, we just discussed with @fabozzi and we agreed the following:
|
|
A new ALCARECO for ECAL trigger studies.
PrimaryDataset: ZeroBias and DoubleEG
To be produced only for few runs on-demand.
@emanueledimarco @nancymarinelli are interested in this PR