Alcareco ecal trg #14684

shervin86 · 2016-05-30T12:26:09Z

A new ALCARECO for ECAL trigger studies.
PrimaryDataset: ZeroBias and DoubleEG

To be produced only for few runs on-demand.

@emanueledimarco @nancymarinelli are interested in this PR

cmsbuild · 2016-05-30T12:26:29Z

A new Pull Request was created by @shervin86 for CMSSW_8_1_X.

It involves the following packages:

Calibration/EcalAlCaRecoProducers
Configuration/AlCa
Configuration/EventContent
Configuration/PyReleaseValidation
Configuration/StandardSequences

@ghellwig, @franzoni, @cerminar, @fabozzi, @cmsbuild, @srimanob, @mmusich, @hengne, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @argiro, @Martin-Grunewald, @tocheng, @VinInn, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

mmusich · 2016-05-30T12:32:07Z

please test

cmsbuild · 2016-05-30T12:32:28Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13256/console

cmsbuild · 2016-05-30T14:26:58Z

-1

Tested at: 05999d6

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14684/13256/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following worklfows:
25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

mmusich · 2016-05-30T16:49:44Z

Calibration/EcalAlCaRecoProducers/python/ALCARECOEcalTrg_Output_cff.py

+        SelectEvents = cms.vstring('pathALCARECOEcalTrg'),
+    ),
+    outputCommands = cms.untracked.vstring( 
+        'CaloTowersSorted_towerMaker_*',


@shervin86 you need to include the keep and drop statements.

----- Begin Fatal Exception 30-May-2016 14:57:08 CEST----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=PoolOutputModule label='ALCARECOStreamEcalTrg' Exception Message: Invalid statement in configuration file In OutputModule parameter named 'outputCommands' Rule must specify 'keep ' or 'drop ' and also supply a pattern. This is the invalid output configuration rule: CaloTowersSorted_towerMaker_* Exception thrown from ProductSelectorRules::Rule ----- End Fatal Exception -------------------------------------------------

yes.... just realized. I've fixed that and running the runTheMatrix to make sure now there are no other problems....

Shervin

On Mon, 30 May 2016, Marco Musich wrote:

Date: Mon, 30 May 2016 18:49:48 +0200
From: Marco Musich notifications@github.com
Reply-To: cms-sw/cmssw
<reply+0045c225ea74ca34bd4e55dd767cf9506c657639cb178a8f92cf000000011364312
c92a170ce03e13aca@reply.github.com>
To: cms-sw/cmssw cmssw@noreply.github.com
Cc: shervin86 shervin@cern.ch, Mention mention@noreply.github.com
Subject: Re: [cms-sw/cmssw] Alcareco ecal trg (#14684)

@@ -0,0 +1,96 @@
+import FWCore.ParameterSet.Config as cms
+
+OutALCARECOEcalTrg_noDrop = cms.PSet(

put this if you have a filter

SelectEvents = cms.untracked.PSet(

SelectEvents = cms.vstring('pathALCARECOEcalTrg'),

),

outputCommands = cms.untracked.vstring(

'CaloTowersSorted_towerMaker_*',

@shervin86 you need to include the keep and drop statements.

----- Begin Fatal Exception 30-May-2016 14:57:08 CEST----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=PoolOutputModule label='ALCARECOStreamEcalTrg' Exception Message: Invalid statement in configuration file In OutputModule parameter named 'outputCommands' Rule must specify 'keep ' or 'drop ' and also supply a pattern. This is the invalid output configuration rule: CaloTowersSorted_towerMaker_* Exception thrown from ProductSelectorRules::Rule ----- End Fatal Exception -------------------------------------------------

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/cms-sw/cmssw/pull/14684/files/05999d6d54d5abf13199e6f5d8e362b14111654b#r65092298

cmsbuild · 2016-05-31T15:24:29Z

Pull request #14684 was updated. @ghellwig, @franzoni, @cerminar, @fabozzi, @cmsbuild, @srimanob, @mmusich, @hengne, @davidlange6 can you please check and sign again.

mmusich · 2016-05-31T15:26:05Z

please test

cmsbuild · 2016-05-31T15:26:23Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13288/console

cmsbuild · 2016-05-31T17:29:11Z

+1
Tested at: b87a6ee
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14684/13288/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
7512f28
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14684/13288/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14684/13288/git-merge-result

cmsbuild · 2016-05-31T19:16:21Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14684/13288/summary.html

cmsbuild · 2016-06-27T09:02:18Z

+1
Tested at: 44cb8e6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14684/13682/summary.html

shervin86 · 2016-06-27T09:24:40Z

urra'

cmsbuild · 2016-06-27T10:03:02Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14684/13682/summary.html

mmusich · 2016-06-27T11:02:28Z

+1

fabozzi · 2016-06-28T14:57:32Z

+1

fabozzi · 2016-08-05T08:14:59Z

Hello, we are experiencing failures due to this backport of EcalTrg to 80X.
The failures showed up in relval MC:
https://hypernews.cern.ch/HyperNews/CMS/get/relval/5632.html

and worst thing, in a re-reco wf on ZeroBias:
https://hypernews.cern.ch/HyperNews/CMS/get/dataopsrequests/14436/1.html

Unless you have better proposals, I think we should remove the EcalTrg path from autoAlca
and relvals.

@mmusich @shervin86 @davidlange6

davidlange6 · 2016-08-05T08:23:35Z

It seems so - but is it obvious why this wasn't seen in 81x relvals? (or was it just ignored there?)

mmusich · 2016-08-05T08:27:23Z

no, simply the run number probed in the RelVals was covered by the correct AlCaRecoTriggerBit.

fwyzard · 2016-08-05T08:28:12Z

On 5 August 2016 at 10:23, David Lange notifications@github.com wrote:

It seems so - but is it obvious why this wasn't seen in 81x relvals? (or
was it just ignored there?)

Is the global tag the same for both releases ?

.A

mmusich · 2016-08-05T08:29:50Z

@fabozzi for the specific use case of the re-reco which GT are you using?

davidlange6 · 2016-08-05T08:30:16Z

ok - so we just need a protection against the alca crashing just because its trigger bit doesn’t happen to be in the menu (and an update to the 81x relvals to cover the region we want to use in 80x (or vis versa..)

On Aug 5, 2016, at 10:27 AM, Marco Musich <notifications@github.com mailto:notifications@github.com> wrote:

no, simply the run number probed in the RelVals was covered by the correct AlCaRecoTriggerBit.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/14684#issuecomment-237787288, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEzyw9pd-A6pS0X38s-oGA1v3rt1Q9Jtks5qcvPtgaJpZM4IpwUu.

mmusich · 2016-08-05T08:31:32Z

@davidlange6 I agree

fabozzi · 2016-08-05T08:31:52Z

@mmusich
this was the rereco on 2015E, so we used the Prompt GT

mmusich · 2016-08-05T08:34:05Z

@fabozzi this explains the failures, since it's not deployed in the standard alcareco matrix we deploy at tier0 the trigger bit is not set in the Prompt GT.
Backporting the IOV back in time to cover 2015E will require a different GT.

mmusich · 2016-08-05T08:42:57Z

So, we just discussed with @fabozzi and we agreed the following:

the re-reco (that is urgent) can be resubmitted removing the AlCa producer from the matrix (N.B. this is needed only because the Prompt GT was used)
in both 80x and 81x I will update the Global Tags to cover the MC use-case
in both 80x and 81x the relval data Run2 is already covered by an IOV, and all future and past runs are OK ----> no action needed

fwyzard · 2016-08-05T08:51:13Z

ok - so we just need a protection against the alca crashing just because its trigger bit doesn’t happen to be in the menu (and an update to the 81x relvals to cover the region we want to use in 80x (or vis versa..)

process.ecalTrgHLT.throw = False

mmusich · 2016-08-05T11:12:27Z

@fabozzi, the issue in 80X MC relvals is hopefully solved at
#15373

cmsbuild added this to the Next CMSSW_8_1_X milestone May 30, 2016

cmsbuild added alca-pending operations-pending pending-signatures tests-pending orp-pending comparison-pending pdmv-pending labels May 30, 2016

cmsbuild added tests-started and removed tests-pending labels May 30, 2016

cmsbuild added tests-rejected and removed tests-started labels May 30, 2016

mmusich reviewed May 30, 2016
View reviewed changes

cmsbuild added tests-pending and removed tests-rejected labels May 31, 2016

cmsbuild added tests-started and removed tests-pending labels May 31, 2016

cmsbuild added tests-approved and removed tests-started labels May 31, 2016

cmsbuild added comparison-available and removed comparison-pending labels May 31, 2016

cmsbuild added tests-started and removed tests-pending labels Jun 27, 2016

cmsbuild added tests-approved and removed tests-started labels Jun 27, 2016

cmsbuild added comparison-available and removed comparison-pending labels Jun 27, 2016

cmsbuild added alca-approved and removed alca-pending labels Jun 27, 2016

cmsbuild added pdmv-approved and removed pdmv-pending labels Jun 28, 2016

davidlange6 merged commit 35e1f91 into cms-sw:CMSSW_8_1_X Jun 28, 2016

shervin86 mentioned this pull request Jun 29, 2016

New ecal trigger alcareco #15052

Merged

shervin86 deleted the ALCARECOEcalTrg branch November 25, 2016 10:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alcareco ecal trg #14684

Alcareco ecal trg #14684

shervin86 commented May 30, 2016 •

edited

Loading

cmsbuild commented May 30, 2016

mmusich commented May 30, 2016

cmsbuild commented May 30, 2016 •

edited

Loading

cmsbuild commented May 30, 2016

mmusich May 30, 2016

shervin86 May 30, 2016

put this if you have a filter

cmsbuild commented May 31, 2016

mmusich commented May 31, 2016

cmsbuild commented May 31, 2016 •

edited

Loading

cmsbuild commented May 31, 2016

cmsbuild commented May 31, 2016

cmsbuild commented Jun 27, 2016

shervin86 commented Jun 27, 2016

cmsbuild commented Jun 27, 2016

mmusich commented Jun 27, 2016

fabozzi commented Jun 28, 2016

fabozzi commented Aug 5, 2016

davidlange6 commented Aug 5, 2016

mmusich commented Aug 5, 2016

fwyzard commented Aug 5, 2016

mmusich commented Aug 5, 2016

davidlange6 commented Aug 5, 2016

mmusich commented Aug 5, 2016

fabozzi commented Aug 5, 2016

mmusich commented Aug 5, 2016

mmusich commented Aug 5, 2016 •

edited

Loading

fwyzard commented Aug 5, 2016

mmusich commented Aug 5, 2016

Alcareco ecal trg #14684

Alcareco ecal trg #14684

Conversation

shervin86 commented May 30, 2016 • edited Loading

cmsbuild commented May 30, 2016

mmusich commented May 30, 2016

cmsbuild commented May 30, 2016 • edited Loading

cmsbuild commented May 30, 2016

mmusich May 30, 2016

Choose a reason for hiding this comment

shervin86 May 30, 2016

Choose a reason for hiding this comment

put this if you have a filter

cmsbuild commented May 31, 2016

mmusich commented May 31, 2016

cmsbuild commented May 31, 2016 • edited Loading

cmsbuild commented May 31, 2016

cmsbuild commented May 31, 2016

cmsbuild commented Jun 27, 2016

shervin86 commented Jun 27, 2016

cmsbuild commented Jun 27, 2016

mmusich commented Jun 27, 2016

fabozzi commented Jun 28, 2016

fabozzi commented Aug 5, 2016

davidlange6 commented Aug 5, 2016

mmusich commented Aug 5, 2016

fwyzard commented Aug 5, 2016

mmusich commented Aug 5, 2016

davidlange6 commented Aug 5, 2016

mmusich commented Aug 5, 2016

fabozzi commented Aug 5, 2016

mmusich commented Aug 5, 2016

mmusich commented Aug 5, 2016 • edited Loading

fwyzard commented Aug 5, 2016

mmusich commented Aug 5, 2016

shervin86 commented May 30, 2016 •

edited

Loading

cmsbuild commented May 30, 2016 •

edited

Loading

cmsbuild commented May 31, 2016 •

edited

Loading

mmusich commented Aug 5, 2016 •

edited

Loading