Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed fit function for vtx and pixel hits distributions from exp to linear + changed LS window #14935

Merged
merged 3 commits into from
Jun 28, 2016

Conversation

dinardo
Copy link
Contributor

@dinardo dinardo commented Jun 21, 2016

Please have a look at PR#14926 ...

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dinardo (Mauro) for CMSSW_8_0_X.

It involves the following packages:

DQM/BeamMonitor
DQM/Integration

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @batinkov this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@dmitrijus
Copy link
Contributor

Please put a proper title, not "Rebasing from PR.......". It does not tell what the PR does, not to me and to David, who will have to +1 this request.

If you are referencing other PRs, please just paste a link to it, for example:
https://github.com/cms-sw/cmssw/pull/14926

it will look like: #14926

@dinardo dinardo changed the title Rebasing from PR in CMSSW_8_1_X Rebasing from PR in CMSSW_8_1_X: PR#14926 Jun 22, 2016
@dinardo
Copy link
Contributor Author

dinardo commented Jun 22, 2016

I"m referring to PR#14926
#14926

@dinardo
Copy link
Contributor Author

dinardo commented Jun 22, 2016

Dear Dmitrijus,
ok I did it.

  • Mauro.

On 22 Jun 2016, at 3:36 PM, Dmitrijus notifications@github.com wrote:

Please put a proper title, not "Rebasing from PR.......". It does not tell what the PR does, not to me and to David, who will have to +1 this request.

If you are referencing other PRs, please just paste a link to it, for example:
#14926

it will look like: #14926


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 24, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13656/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

@dinardo - please change the title of this PR to be descriptive of the changes it proposes for our release notes. Thanks!

@dinardo dinardo changed the title Rebasing from PR in CMSSW_8_1_X: PR#14926 Changed fit function for vtx and pixel hits distributions from exp to linear + changed LS window Jun 28, 2016
@dinardo
Copy link
Contributor Author

dinardo commented Jun 28, 2016

Hi David,
sure, done.

Cheers,

  • Mauro.

On 28 Jun 2016, at 7:14 PM, David Lange notifications@github.com wrote:

@dinardo - please change the title of this PR to be descriptive of the changes it proposes for our release notes. Thanks!


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7829170 into cms-sw:CMSSW_8_0_X Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants