Protection against empty globalDirs

[BetterWang]

Protection against empty vector.

[cmsbuild]

A new Pull Request was created by @BetterWang (Quan Wang) for CMSSW_7_5_X.

It involves the following packages:

RecoPixelVertexing/PixelLowPtUtilities

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @dgulhan, @rovere, @VinInn this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[VinInn]

@cmsbuild , please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13764/console

[slava77]

Once the tests pass, we need a matching fix in 81X (not sure about 80X).
Will this code be used in pPb workflows?

[BetterWang]

I don't think this code is run for pp reconstruction.

[cmsbuild]

-1

Tested at: eecbc97

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15053/13764/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

[BetterWang]

I dont think failure is related to the PR.

[slava77]

@BetterWang
please update the PR title (there is an "Edit" button top right) to be more descriptive what is fixed and where

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13771/console

[cmsbuild]

+1
Tested at: eecbc97
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15053/13771/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15053/13771/summary.html

[slava77]

@BetterWang
Please make PRs for 80X and 81X

[slava77]

+1

for #15053 eecbc97

• fixes a crash that shows up with RecoHI.Configuration.customise_RecoMergedTrackCollection.customiseAddMergedTrackCollection setting of hiConformalPixelTracks.FilterPSet.useClusterShape = cms.bool(True) to be used in partial PbPb data reprocessing
• jenkins tests pass and comparisons show no difference
• local tests with provided instructions and run_262818_evt_16830883 input confirm that the crash is gone.

@davidlange6 this is the last PR needed for the 75X release request.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar