Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protection against empty globalDirs #15101

Merged

Conversation

BetterWang
Copy link
Contributor

(cherry picked from commit eecbc97)
Protection against empty vector.
Same as #15053

(cherry picked from commit eecbc97)
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2016

A new Pull Request was created by @BetterWang (Quan Wang) for CMSSW_8_0_X.

It involves the following packages:

RecoPixelVertexing/PixelLowPtUtilities

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @dgulhan, @rovere, @VinInn this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Jul 2, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/13856/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2016

@slava77
Copy link
Contributor

slava77 commented Jul 5, 2016

+1

for #15101 14c24ec

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants