Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REBASED Pr81x l1t-tsg-v9 (part 2) for Sept 2016 MC production #15757

Merged
merged 127 commits into from Sep 12, 2016
Merged

REBASED Pr81x l1t-tsg-v9 (part 2) for Sept 2016 MC production #15757

merged 127 commits into from Sep 12, 2016

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Sep 7, 2016

This is the rebased version of #15746.

rekovic and others added 30 commits September 7, 2016 10:59
@rekovic
Merged CMSSW_8_1_X from repository cms-sw
a7ed426
@abrinke1 @rekovic
EMTF emulator files standard tabbing; bit-wise identical performance
cb1400c
@abrinke1 @rekovic
EMTF emulator small fix to LCT theta assignment
1d43394
@abrinke1 @rekovic
EMTF emulator configurable BX shift for input hits
64605bd
@eparadas @rekovic
New quality is included. The unpacker for the inputs is slightly changed
016850b
@eparadas @rekovic
Change in the if statement
d11ee26
@eparadas @rekovic
Adding FW version
fdda441
@eparadas @rekovic
Update BMTFUnpackerInputs.cc
be2fe60 
eta hits & quality will be written in the same order as they are read
@blwiner @rekovic
First changes for multiboard uGT operation
5f57c1c
@rekovic
Go back to not packing ExtBlk when packing uGT payloads
0a3156c
@jingyucms @rekovic
add PU information in the n-tuple
479001e
@apana @rekovic
Remove delete tree_ from destructor, it erases the uGT ntuple
76258d9
@blwiner @rekovic
Updates for uGT unit tests
df3214c
@abrinke1 @rekovic
EMTF emulator fix for global phi and sector of sector-overlap tracks
cb0d964
@rekovic
Added event filter for requiring calo towers for events
16a97d5
@rekovic
Added the correct reference to the calo towers in the event filter an…
e15c6f6 
…d added relevant calo stage 2 params file
@bundocka @rekovic
Jet finder now covers full HF
d25e4b5
@bundocka @rekovic
Jet demux eta fix
f481e33
@bundocka @rekovic
Fixed sum eta range for ETT with HF
69f3a12
@bundocka @rekovic
Updated caloStage2Params2016 v2.2 with correct eta range for sumEt wi…
59633db 
…th HF
@rekovic
Added new sum quantities to unpacker
f68047b
@bundocka @rekovic
Added HF histos, switched kMissingEt2 to kMissingEtHF
8f69802
@rekovic
Added ETT with HF to Et sum algorithm as an additional sum
cbac938
@konec @rekovic
fixes towards better data-emulator agreement
2b9e3e9
@l-cadamuro @rekovic
tau accumulated sort
aecb8bf
@konec @rekovic
clean warning, remove unnecessary bitset, in favout of 0b....
6ab60c6
@bundocka @rekovic
Fix to cosine coefficients
c73b011
@bundocka @rekovic
merge conflicts resolved
678a712
@bundocka @rekovic
Update jet sort and tidy up
8e54646
@bundocka @rekovic
Few changes from kHFEnd to kHFEnd-1 (use MP eta def) warning fix
aa3c41f
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 12, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15086/console

@cmsbuild
Copy link
Contributor

-1

Tested at: a301eac

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15757/15086/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
1003.0 step1

DAS Error

@rekovic
Copy link
Contributor Author

rekovic commented Sep 12, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 12, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15090/console

@cmsbuild
Copy link
Contributor

+1
Tested at: a301eac
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15757/15090/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15757/15090/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • 136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2

@civanch
Copy link
Contributor

civanch commented Sep 12, 2016

+1

@rekovic
Copy link
Contributor Author

rekovic commented Sep 12, 2016

@slava77 @davidlange6 How do we proceed with the problem with the test above due to missing matrix map?

@davidlange6
Copy link
Contributor

@rekovic - not to worry for now - but please start working on the changes needed for the back port...

@davidlange6 davidlange6 merged commit a25ddf5 into cms-sw:CMSSW_8_1_X Sep 12, 2016
This was referenced Sep 12, 2016
Closed
Merged
Closed
@rekovic rekovic mentioned this pull request Sep 25, 2016
Merged
@silviodonato silviodonato mentioned this pull request Nov 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available l1-approved operations-pending orp-pending pending-signatures simulation-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet