Add L1 ETMHF as HLT objects

[silviodonato]

The new L1 objects defined with #15757 were not included in HLTL1TSeed module.
As a results, we had events passing L1_ETMHFXX but without any trigger objects.
This was an issue for study the L1/HLT trigger efficiency.

This PR fixes this issue adding L1 ETMHF as a new trigger objects format and using it in HLTL1TSeed.
Please note that the other formats (ETTHF, HTTHT, and HTMHF) added with #15757 are not present in
/DataFormats/L1TGlobal/interface/GlobalObject.h , ie. l1t:gtHTMHF, l1t:gtHTTHF, l1t:gtETTHF are not defined.

See https://its.cern.ch/jira/browse/CMSHLT-1701

[silviodonato]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21444/2168

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24651/console Started: 2017/11/23 14:14

[cmsbuild]

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

DataFormats/HLTReco
HLTrigger/HLTfilters

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @rovere this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Tested at: 797e079

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
0a3cf1a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21444/24651/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21444/24651/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21444/24651/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test runtestTqafExamples had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
0a3cf1a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21444/24651/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21444/24651/git-merge-result

[cmsbuild]

Comparison job queued.

[silviodonato]

I'm pretty sure it is not related with this PR ...
The error is

An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 2 stream: 0
   [1] Running path 'p1'
   [2] Prefetching for module TopTauAnalyzer/'analyzeTau'
   [3] Prefetching for module PATTauSelector/'selectedPatTaus'
   [4] Calling method for module PATTauProducer/'patTaus'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: reco::PFTauDiscriminator
Looking for module label: hpsPFTauDiscriminationByVVLooseIsolationMVArun2v1DBoldDMwLT
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------```

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21444/24651/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2833444
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2833265
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.36000000007 KiB( 23 files compared)
• Checked 111 log files, 8 edm output root files, 27 DQM output files

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24664/console Started: 2017/11/24 06:38

[cmsbuild]

+1
Tested at: 797e079
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21444/24664/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
56584e3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21444/24664/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21444/24664/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21444/24664/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2833444
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2833265
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.629999999939 KiB( 23 files compared)
• Checked 111 log files, 8 edm output root files, 27 DQM output files

[silviodonato]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1