Fixing neglected gen filters from HepMC renaming #16287
Conversation
|
A new Pull Request was created by @kurtejung (Kurt Jung) for CMSSW_8_0_X. It involves the following packages: GeneratorInterface/GenFilters @cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
fully-signed
generators-approved
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
Comparison job queued. |
|
@kurtejung please port this PR also to 81X and cross-reference it, thanks |
|
also, I see that you only changed 3 filters. Did you check them all? If there are others that need this fix, may I very kindly ask you to change them all in one PR? That would be a great service for the whole GEN community, thanks |
|
Most of the gen filters seem to already have this fix, e.g. https://github.com/cms-sw/cmssw/blob/CMSSW_8_0_X/GeneratorInterface/GenFilters/src/PythiaFilter.cc Some of the filters clearly require the user to override the default settings (e.g. https://github.com/cms-sw/cmssw/blob/CMSSW_8_0_X/GeneratorInterface/GenFilters/src/MCLongLivedParticles.cc) and others use the genParticles. It may be good to go through these filters in a more systematic way and change all the default values of those that use a HepMC input to "generator::unsmeared" but I was afraid of breaking filters. Please advise. |
|
Maybe @wmtan can describe why only some of the gen filters default collections were renamed from "generator" to "generator : unsmeared" |
|
as mentioned by George via mail, also |
|
All gen filters (both HI and pp) should be updated to properly use the unsmeared HepMC collections now - can one of the managers run tests? Thanks. |
|
please test |
|
The tests are being triggered in jenkins. |
|
please port this PR also to 81X and cross-reference it, thanks |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
fully-signed
generators-approved
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
corresponding PR in 81X here #16331 |
|
hi @davidlange6, this should have gone to 8_0_22 |
|
+1 |
|
as usual a note in the ORP is what will get your PRs merged…
|
|
@davidlange6 : A note in the google doc or the twiki? Can anyone add a note or is that only for those who sign? |
|
anyone can add a note (though indeed the idea is that the signing areas take responsibility for knowing what code in their area is needed where...
|
HepMC naming migration from commit (here: f719245) neglected to rename the inputs to a few gen filters needed for HI production
Also pinging @mandrenguyen @yetkinyilmaz @bendavid