Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Gen filters to use unsmeared HepMC Product #16331

Merged
merged 1 commit into from Oct 25, 2016
Merged

Fixing Gen filters to use unsmeared HepMC Product #16331

merged 1 commit into from Oct 25, 2016

Conversation

kurtejung
Copy link
Contributor

Repeat of PR #16287 for 81X

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Oct 24, 2016
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kurtejung (Kurt Jung) for CMSSW_8_1_X.

It involves the following packages:

GeneratorInterface/GenFilters

@cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks.
@agrohsje, @mkirsano this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@perrozzi
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 24, 2016 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/15936/console

@perrozzi
Copy link
Contributor

80X backport here #16287

@perrozzi perrozzi mentioned this pull request Oct 24, 2016
Merged
@cmsbuild
Copy link
Contributor

+1
Tested at: 4e14a48
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16331/15936/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16331/15936/summary.html

@perrozzi
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@davidlange6 davidlange6 merged commit 2c2e523 into cms-sw:CMSSW_8_1_X Oct 25, 2016
@sviret sviret mentioned this pull request Mar 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed generators-approved orp-pending tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kurtejung @cmsbuild @perrozzi @davidlange6