add PV monitoring @HLT #18191

mtosi · 2017-04-04T09:35:58Z

backport of PR #18074

fix bug fix add ndof add PV monitoring@HLT for online DQM

@makortel

Ignore vertex collections for which the track refs are null (as done by @makortel in 336f8af) Print LogWarning once per stream in case of missing input collection (as done by @makortel in 0b5aad4) fix PVV@HLT fix

@Fake

fix VALIDATION step in workflows w/ HLT:@Fake fix fix fix DQM step as well !

fix add PAGs client fix fix handling of condDataValidation fix HARVESTING step in run1 no HLT Validation HARVESTING and no HLT DQM HARVESTING re-fix

fix fix

@makortel

fix bug fix add ndof add PV monitoring@HLT for online DQM Conflicts: DQMOffline/RecoB/plugins/PrimaryVertexMonitor.cc DQMOffline/RecoB/plugins/PrimaryVertexMonitor.h Ignore vertex collections for which the track refs are null Print LogWarning once per stream in case of missing input collection Ignore vertex collections for which the track refs are null (as done by @makortel in 336f8af) Print LogWarning once per stream in case of missing input collection (as done by @makortel in 0b5aad4) fix PVV@HLT fix Conflicts: DQMOffline/RecoB/plugins/PrimaryVertexMonitor.h add standardValidationNoHLT fix VALIDATION step in workflows w/ HLT:@Fake fix fix fix DQM step as well ! Conflicts: Configuration/PyReleaseValidation/python/relval_steps.py add main PAGs sequence for offline DQM fix add PAGs client fix fix handling of condDataValidation fix HARVESTING step in run1 no HLT Validation HARVESTING and no HLT DQM HARVESTING Conflicts: Configuration/PyReleaseValidation/python/relval_steps.py re-fix fix fix

cmsbuild · 2017-04-04T09:36:18Z

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_9_0_X.

It involves the following packages:

Configuration/PyReleaseValidation
Configuration/StandardSequences
DQM/HLTEvF
DQMOffline/Configuration
DQMOffline/RecoB
DQMOffline/Trigger
SimTracker/VertexAssociation
Validation/Configuration
Validation/RecoVertex

@perrotta, @cmsbuild, @civanch, @dmitrijus, @silviodonato, @fwyzard, @mdhildreth, @fabozzi, @Martin-Grunewald, @franzoni, @kpedro88, @slava77, @GurpreetSinghChahal, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @felicepantaleo, @Martin-Grunewald, @threus, @venturia, @battibass, @makortel, @acaudron, @sdevissc, @jhgoh, @HuguesBrun, @ferencek, @trocino, @rociovilar, @GiacomoSguazzoni, @rovere, @VinInn, @ebrondol, @dgulhan, @imarches, @calderona, @mverzett, @JyothsnaKomaragiri, @pvmulder this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

Martin-Grunewald · 2017-04-04T10:57:17Z

please test

cmsbuild · 2017-04-04T10:57:35Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18906/console Started: 2017/04/04 12:58

dmitrijus · 2017-04-04T11:02:52Z

+1

cmsbuild · 2017-04-04T11:08:24Z

-1

Tested at: 992c499

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18191/18906/summary.html

I found follow errors while testing this PR

Failed tests: Build

Build:

I found an error when building:

>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-04-03-2300/src/DQMServices/Core/bin/MergeFile.cpp 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-04-03-2300/src/DQMServices/Core/test/DQMTestStandaloneBuildOfDQMStore.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-04-03-2300/src/DQMServices/Core/test/DQMFastMatchTest.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-04-03-2300/src/DQMServices/Core/test/DQMQualityTestsExample.cc 
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-04-03-2300/src/SLHCUpgradeSimulations/Geometry/src/PrintGeomMatInfo.cc: In member function 'void PrintGeomMatInfo::dumpSummary(std::ostream&)':
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-04-03-2300/src/SLHCUpgradeSimulations/Geometry/src/PrintGeomMatInfo.cc:177:11: error: 'G4PhysicalVolumeStore' does not name a type
     const G4PhysicalVolumeStore * pvs = G4PhysicalVolumeStore::GetInstance();
           ^
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-04-03-2300/src/SLHCUpgradeSimulations/Geometry/src/PrintGeomMatInfo.cc:178:50: error: 'pvs' was not declared in this scope
     out << " Number of G4VPhysicalVolume's: " << pvs->size() << std::endl;
                                                  ^

cmsbuild · 2017-04-04T11:35:12Z

Pull request #18191 was updated. @perrotta, @cmsbuild, @civanch, @dmitrijus, @silviodonato, @fwyzard, @mdhildreth, @fabozzi, @Martin-Grunewald, @franzoni, @kpedro88, @slava77, @GurpreetSinghChahal, @vanbesien, @davidlange6 can you please check and sign again.

perrotta · 2017-04-04T16:25:33Z

please test

cmsbuild · 2017-04-04T16:25:54Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18915/console Started: 2017/04/04 18:28

cmsbuild · 2017-04-04T18:26:22Z

+1
Tested at: 1dfbc73
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18191/18915/summary.html

cmsbuild · 2017-04-04T18:26:25Z

Comparison job queued.

cmsbuild · 2017-04-04T19:36:46Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18191/18915/summary.html

perrotta · 2017-04-04T19:55:07Z

+1
Same as #18074 in 91X

Martin-Grunewald · 2017-04-05T07:20:08Z

+1

kpedro88 · 2017-04-05T07:20:57Z

+1

dmitrijus · 2017-04-05T09:47:20Z

+1

civanch · 2017-04-05T10:15:03Z

+1

mtosi and others added 9 commits April 3, 2017 11:05

add validation of hltVerticesPFFilter collection

21e385e

add PV monitoring @HLT

bf69930

add vertex monitoring @HLT to online DQM as well

0855c82

fix bug fix add ndof add PV monitoring@HLT for online DQM

Ignore vertex collections for which the track refs are null

fd2be4a

Print LogWarning once per stream in case of missing input collection

f5c31f4

Ignore vertex collections for which the track refs are null (as done by @makortel in 336f8af) Print LogWarning once per stream in case of missing input collection (as done by @makortel in 0b5aad4) fix PVV@HLT fix

add standardValidationNoHLT

e8f6892

fix VALIDATION step in workflows w/ HLT:@Fake fix fix fix DQM step as well !

add main PAGs sequence for offline DQM

5908a3c

fix add PAGs client fix fix handling of condDataValidation fix HARVESTING step in run1 no HLT Validation HARVESTING and no HLT DQM HARVESTING re-fix

dropping DB from METMonitoring

74fd4cc

fix fix

cmsbuild added this to the Next CMSSW_9_0_X milestone Apr 4, 2017

cmsbuild added comparison-pending dqm-pending hlt-pending operations-pending orp-pending pdmv-pending pending-signatures reconstruction-pending simulation-pending tests-pending upgrade-pending labels Apr 4, 2017

cmsbuild added tests-started and removed tests-pending labels Apr 4, 2017

cmsbuild added dqm-approved and removed dqm-pending labels Apr 4, 2017

cmsbuild added dqm-pending tests-pending labels Apr 4, 2017

cmsbuild added tests-started and removed tests-pending labels Apr 4, 2017

cmsbuild added tests-approved and removed tests-started labels Apr 4, 2017

cmsbuild added comparison-available and removed comparison-pending labels Apr 4, 2017

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Apr 4, 2017

cmsbuild added hlt-approved and removed hlt-pending labels Apr 5, 2017

cmsbuild added upgrade-approved and removed upgrade-pending labels Apr 5, 2017

cmsbuild added dqm-approved and removed dqm-pending labels Apr 5, 2017

cmsbuild added simulation-approved and removed simulation-pending labels Apr 5, 2017

davidlange6 merged commit 9476e21 into cms-sw:CMSSW_9_0_X Apr 12, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add PV monitoring @HLT #18191

add PV monitoring @HLT #18191

mtosi commented Apr 4, 2017

cmsbuild commented Apr 4, 2017

Martin-Grunewald commented Apr 4, 2017

cmsbuild commented Apr 4, 2017 •

edited

dmitrijus commented Apr 4, 2017

cmsbuild commented Apr 4, 2017

cmsbuild commented Apr 4, 2017

perrotta commented Apr 4, 2017

cmsbuild commented Apr 4, 2017 •

edited

cmsbuild commented Apr 4, 2017

cmsbuild commented Apr 4, 2017

cmsbuild commented Apr 4, 2017

perrotta commented Apr 4, 2017

Martin-Grunewald commented Apr 5, 2017

kpedro88 commented Apr 5, 2017

dmitrijus commented Apr 5, 2017

civanch commented Apr 5, 2017

add PV monitoring @HLT #18191

add PV monitoring @HLT #18191

Conversation

mtosi commented Apr 4, 2017

cmsbuild commented Apr 4, 2017

Martin-Grunewald commented Apr 4, 2017

cmsbuild commented Apr 4, 2017 • edited

dmitrijus commented Apr 4, 2017

cmsbuild commented Apr 4, 2017

cmsbuild commented Apr 4, 2017

perrotta commented Apr 4, 2017

cmsbuild commented Apr 4, 2017 • edited

cmsbuild commented Apr 4, 2017

cmsbuild commented Apr 4, 2017

cmsbuild commented Apr 4, 2017

perrotta commented Apr 4, 2017

Martin-Grunewald commented Apr 5, 2017

kpedro88 commented Apr 5, 2017

dmitrijus commented Apr 5, 2017

civanch commented Apr 5, 2017

cmsbuild commented Apr 4, 2017 •

edited

cmsbuild commented Apr 4, 2017 •

edited