Using Puppi candidates for b tagging + DeepCSV in MiniAOD for Phase 2 #18260
Conversation
|
A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_9_0_X. It involves the following packages: PhysicsTools/PatAlgos @perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| _pfCandidates = 'particleFlow' | ||
| _discriminatorSources = copy.deepcopy(process.patJets.discriminatorSources) | ||
| from Configuration.Eras.Modifier_phase2_common_cff import phase2_common | ||
| if process.isUsingModifier( phase2_common ): |
There was a problem hiding this comment.
@Dr15Jones
is "isUsingModifier" OK to use?
|
@ferencek |
|
@slava77, this is intended for Phase 2 MiniAOD production for Muon/ECAL barrel TDR. My understanding was that this would be done in 90X. There are two changes in this PR, one that switches the b tagging input to Puppi candidates and the other one that adds additional b tag discriminators. The former change could in principle be added to 91X but the latter one is supposed to be superseded in 91X by a general update of the list of b tag discriminators added to PAT jets. In short, a verbatim forward port of this PR to 91X is not what is needed. |
|
assign upgrade |
|
New categories assigned: upgrade @kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks |
|
in any case (90X or not) there has to be a PR in 91X (master branch) merged first before production release updates can be considered. |
|
OK, I will wait for Kevin's confirmation about 91X. For the 91X PR, the code changes will have to be organized a bit differently. |
|
Yes, muon/barrel TDR will use 91X |
This PR switches the input candidate collection used in b tagging from the default Particle flow candidates (
particleFlow) to Puppi candidates (pupi) for the Phase 2 era. In addition, the DeepCSV discriminators are added to ak4 Puppi jets in MiniAOD for the Phase 2 era.These changes only affect MiniAOD, more specifically ak4 Puppi jets, for the Phase 2 era.
@gpetruc