Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppi candidates for b tagging of Puppi jets in MiniAOD for Phase 2 #18317

Conversation

ferencek
Copy link
Contributor

This PR switches the input candidate collection used in b tagging from the default Particle-flow candidates (particleFlow) to Puppi candidates (pupi) for Phase 2. These changes only affect MiniAOD, more specifically ak4 Puppi jets, for the Phase 2 era.

This is related to #18260 but does not add new b-tag discriminators since they are now added in #18315

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @JyothsnaKomaragiri this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Apr 11, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 11, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19113/console Started: 2017/04/11 20:30

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18317/19113/summary.html

Comparison Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1921107
  • DQMHistoTests: Total failures: 112
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1920822
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@slava77
Copy link
Contributor

slava77 commented Apr 18, 2017

@ferencek
why not switch to PUPPI for btags of PUPPI-based jets for all eras?
The phase-2 specialization seems unnecessary.

@slava77
Copy link
Contributor

slava77 commented Apr 19, 2017

@imarches (in case @ferencek is away)
please clarify why the switch here is done only for phase-2

@ferencek
Copy link
Contributor Author

@slava77, there have been some studies going in that direction:

In both cases there are no significant improvements observed and for ak4 jets things are further complicated by the fact that in some cases the performance curves for the two cases (current default and the explicit JTA) cross each other so neither of the two cases is uniformly better or worse.

Only in extremely high PU scenarios encountered in Phase II does Puppi start to make a difference. This is probably because it dramatically reduces the number of tracks associated to any given jet significantly reducing the combinatorial background. The bottom line is that there is no strong reason to switch to Puppi candidates as input for b tagging for scenarios other than Phase II.

@slava77
Copy link
Contributor

slava77 commented Apr 19, 2017 via email

@ferencek
Copy link
Contributor Author

@slava77, I think more studies are needed before this type of change is possibly introduced for Phase 1.

However, I understand you point about uniform configuration. That would definitely make life and code maintenance easier. But I'm also afraid that that is too idealistic to expect and Phase 2 stuff will likely require special treatment for quite some time. It corresponds to dramatically different running conditions and we still have very preliminary detector description in the simulation as well as very preliminary reconstruction so insisting on some changes in Phase 0 and 1 just to be uniform with some preliminary configuration for Phase 2 seems premature to me.

@slava77
Copy link
Contributor

slava77 commented Apr 20, 2017

It looks like the arguments so far reduce to "we want to be safe by staying with a historical choice for phase-1/0 and haven't had time to check".

References provided appear to be rather old and have much smaller PU than late 2016 or 2017 and probably work out differently with the latest PUPPI tunes.
I'd expect that in absolute PU value the gain from using puppi consistently should become evident for smaller PU in phase-0 or 1 than for phase-2.
This is due to pixel-seed-only tracking in phase-2 vs pixel and strip mix in phase-0/1.
So, PU70 now may look just as similar as PU140 in phase-2 and you'd have switched consistently if the checks were made already.

I'll sign but will make an issue to be followed up hopefully soon.

@slava77
Copy link
Contributor

slava77 commented Apr 20, 2017

+1

for #18317 76fb1c9

  • changes are as described; they affect only jets saved in miniAOD (for what concerns reco/production workflows)
  • jenkins tests pass and comparisons with baseline show no differences (the miniAOD btag values are not monitored)
  • switching to puppi candidate based tagging for puppi jets #18426 is created to follow up and possibly switch to the same selection for all eras

@davidlange6 davidlange6 merged commit 77fe450 into cms-sw:master Apr 21, 2017
@ferencek ferencek deleted the Phase2PuppiForBTagging_from-CMSSW_9_1_0_pre2 branch April 21, 2017 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants