Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pr91x l1t prescales from payloads rebased #18428

Merged
merged 16 commits into from Apr 27, 2017
Merged

Pr91x l1t prescales from payloads rebased #18428

merged 16 commits into from Apr 27, 2017

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Apr 20, 2017

Rebased #17721.

Updated L1TGlobalUtil to now also access L1T prescales from payloads, using GlobalTag.

apana and others added 15 commits February 14, 2017 15:57
@apana @rekovic
Update to read L1 prescales from dB
f1623b3
@apana @rekovic
cfi for when running uGT emulator
fc489c5
@rekovic
Post conflict cleanup: remove duplicate function declaration.
db513e2
@rekovic
Include header for MessageLogger.
e14dbd7
@rekovic
Fix the missing configuration ReadPrescalesFromFile parameter in DQM …
255cf62 
…module after the change in L1TGlobalUtils.
@rekovic
Cout back to LogVerbatim.
b246965
@rekovic
Fix the missing configuration ReadPrescalesFromFile parameter in PATT…
1cc365e 
…riggerProducer configuration file.
@rekovic
Clean up: remove cout.
472deb4
@rekovic
Clean up l1tGlobalSummary_cfi file for some parametrs provided in fil…
36656de 
…lDescription() method.
@rekovic
Use the system plugins generated L1TGlobalSummary_cfi.py and depricat…
6537077 
…e by hand made l1tGlobalSummary_cfi.py.
@rekovic
For testing: change default value of ReadPrescalesFromFile to true - …
26da966 
…should reproduce all results with reference IB release.
@rekovic
Do the same in helper.
70159e1
@rekovic
Revert "Do the same in helper."
7d9ca3a 
This reverts commit 70159e1.
@rekovic
Revert "For testing: change default value of ReadPrescalesFromFile to…
7181056 
… true - should reproduce all results with reference IB release."

This reverts commit 26da966.
@rekovic
Merged refs/pull/17721/head from repository cms-sw
de03d3e 
Conflicts:
	L1Trigger/L1TGlobal/plugins/GtRecordDump.cc
@cmsbuild cmsbuild added this to the Next CMSSW_9_1_X milestone Apr 20, 2017
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rekovic for master.

It involves the following packages:

DQM/SiStripMonitorClient
L1Trigger/L1TGlobal
PhysicsTools/PatAlgos

@perrotta, @monttj, @dmitrijus, @cmsbuild, @rekovic, @slava77, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @rappoccio, @Martin-Grunewald, @fioriNTU, @threus, @venturia, @mmarionncern, @kreczko, @hdelanno, @imarches, @ahinzmann, @acaudron, @jdolen, @ferencek, @nhanvtran, @gkasieczka, @schoef, @idebruyn, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@rekovic
Copy link
Contributor Author

rekovic commented Apr 20, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 20, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19308/console Started: 2017/04/20 23:51

@rekovic
Copy link
Contributor Author

rekovic commented Apr 20, 2017

+1

@cmsbuild
Copy link
Contributor

Pull request #18428 was updated. @perrotta, @monttj, @dmitrijus, @cmsbuild, @rekovic, @slava77, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again.

@rekovic
Copy link
Contributor Author

rekovic commented Apr 24, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 24, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19345/console Started: 2017/04/24 18:16

@cmsbuild
Copy link
Contributor

+1
Tested at: 9ff4110
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18428/19345/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18428/19345/summary.html

Comparison Summary:

  • You potentially added 9 lines to the logs
  • Reco comparison results: 1615 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1780110
  • DQMHistoTests: Total failures: 39403
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1740534
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@rekovic
Copy link
Contributor Author

rekovic commented Apr 24, 2017

+1

@perrotta
Copy link
Contributor

+1
Changes applied in the last commits are fine with reco
I can confirm my "+1" as in #18428 (comment)

@rekovic
Copy link
Contributor Author

rekovic commented Apr 25, 2017

@dmitrijus please re-sign

@dmitrijus
Copy link
Contributor

+1

@davidlange6 davidlange6 merged commit 5a546be into cms-sw:master Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlange6 davidlange6 davidlange6 left review comments

Assignees
No one assigned
Labels
analysis-pending comparison-available dqm-approved l1-approved orp-pending pending-signatures reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_1_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rekovic @cmsbuild @perrotta @dmitrijus @davidlange6 @apana