Pr90x l1t prescales from payloads #17721

cmsbuild · 2017-03-02T12:34:07Z

90x PR: Updated L1TGlobalUtil to now also access L1T prescales from payloads, using GlobalTag.

Example:

cmsRun L1Trigger/L1TGlobal/test/runGTSummary.py

Automatically ported from CMSSW_9_0_X #17512 (original by @cms-l1t-offline).
Please wait for a new IB (12 to 24H) before requesting to test this PR.

…module after the change in L1TGlobalUtils.

cmsbuild · 2017-03-02T12:36:05Z

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

DQM/SiStripMonitorClient
L1Trigger/L1TGlobal
L1Trigger/L1TMuonEndCap

@dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@kreczko, @hdelanno, @Martin-Grunewald, @fioriNTU, @idebruyn, @threus, @venturia this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

…riggerProducer configuration file.

cmsbuild · 2017-03-26T11:48:30Z

Pull request #17721 was updated. @perrotta, @monttj, @dmitrijus, @cmsbuild, @rekovic, @slava77, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again.

rekovic · 2017-03-26T11:49:23Z

The above commit does not fix it all the way, but the configuration parameter is needed.

rekovic · 2017-03-26T11:49:28Z

please test

cmsbuild · 2017-03-26T11:49:39Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18705/console Started: 2017/03/26 13:51

cmsbuild · 2017-03-26T13:46:11Z

-1

Tested at: 1cc365e

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17721/18705/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_1_X_2017-03-25-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Sun Mar 26 15:33:22 2017-date Sun Mar 26 15:27:32 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Sun Mar 26 15:33:22 2017-date Sun Mar 26 15:27:32 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_1_X_2017-03-25-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Sun Mar 26 15:42:17 2017-date Sun Mar 26 15:27:40 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Sun Mar 26 15:42:17 2017-date Sun Mar 26 15:27:40 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_1_X_2017-03-25-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Sun Mar 26 15:39:27 2017-date Sun Mar 26 15:27:46 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Sun Mar 26 15:39:27 2017-date Sun Mar 26 15:27:46 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_1_X_2017-03-25-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun2016.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Sun Mar 26 15:42:12 2017-date Sun Mar 26 15:27:51 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun2016,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun2016 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun2016_MC.root --fileout file:RelVal_Raw_GRun2016_MC_HLT_RECO.root : FAILED - time: date Sun Mar 26 15:42:12 2017-date Sun Mar 26 15:27:51 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_1_X_2017-03-25-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Sun Mar 26 15:32:26 2017-date Sun Mar 26 15:27:54 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Sun Mar 26 15:32:26 2017-date Sun Mar 26 15:27:54 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_1_X_2017-03-25-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Sun Mar 26 15:38:51 2017-date Sun Mar 26 15:27:56 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Sun Mar 26 15:38:51 2017-date Sun Mar 26 15:27:56 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_1_X_2017-03-25-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Sun Mar 26 15:39:14 2017-date Sun Mar 26 15:28:01 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_MC.root --fileout file:RelVal_Raw_Fake2_MC_HLT_RECO.root : FAILED - time: date Sun Mar 26 15:39:14 2017-date Sun Mar 26 15:28:01 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_1_X_2017-03-25-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Sun Mar 26 15:39:03 2017-date Sun Mar 26 15:28:10 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Sun Mar 26 15:39:03 2017-date Sun Mar 26 15:28:10 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_1_X_2017-03-25-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Sun Mar 26 15:39:44 2017-date Sun Mar 26 15:28:16 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Sun Mar 26 15:39:44 2017-date Sun Mar 26 15:28:16 2017 s - exit: 16640

cmsbuild · 2017-03-26T13:46:13Z

Comparison job queued.

cmsbuild · 2017-03-26T15:08:37Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17721/18705/summary.html

cmsbuild · 2017-04-12T17:13:11Z

Pull request #17721 was updated. @perrotta, @monttj, @dmitrijus, @cmsbuild, @rekovic, @slava77, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again.

rekovic · 2017-04-12T17:16:26Z

As discussed in the ORP meeting, the test comparison histograms are often a red herring,
and did not provide information pointing to problems with this PR.

rekovic · 2017-04-12T17:17:28Z

Reverted to configuration with a default setup that uses GT for prescales.

rekovic · 2017-04-12T17:17:33Z

+1

cmsbuild · 2017-04-12T17:17:47Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19154/console Started: 2017/04/12 19:22

cmsbuild · 2017-04-12T19:42:02Z

+1
Tested at: 7181056
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17721/19154/summary.html

cmsbuild · 2017-04-12T19:42:05Z

Comparison job queued.

cmsbuild · 2017-04-12T22:08:10Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17721/19154/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 1630 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1921525
DQMHistoTests: Total failures: 24384
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1896968
DQMHistoTests: Total skipped: 173
DQMHistoTests: Total Missing objects: 0
Checked 94 log files, 14 edm output root files, 23 DQM output files

rekovic · 2017-04-14T13:58:44Z

@davidlange6 We would like this for 9_1_0_pre3, if possible.

rekovic · 2017-04-14T18:37:59Z

@perrotta, @monttj, @slava77, please sign or comment.

perrotta · 2017-04-19T12:23:47Z

+1

Reco enters through PhysicsTools/PatAlgos/python/triggerLayer1/triggerProducer_cfi.py , where one parameter was added to a configuration for a PATTriggerProducer
Checked in jenkins: no changes
Comments received from L1/HLT are now integrated

davidlange6 · 2017-04-19T18:43:34Z

Hi @rekovic - please fix the merge conflict. Thanks

rekovic · 2017-04-20T21:50:45Z

@davidlange6 Done with #18428. Started tests and L1T signed.

dmitrijus · 2017-04-21T14:09:21Z

Since you opened a second pull request, please close this one.

Ideally, it would be for the best if you just reused this PR. :)

apana and others added 6 commits February 14, 2017 15:57

Update to read L1 prescales from dB

f1623b3

cfi for when running uGT emulator

fc489c5

Post conflict cleanup: remove duplicate function declaration.

db513e2

Include header for MessageLogger.

e14dbd7

Fix the missing configuration ReadPrescalesFromFile parameter in DQM …

255cf62

…module after the change in L1TGlobalUtils.

Cout back to LogVerbatim.

b246965

cmsbuild added this to the Next CMSSW_9_1_X milestone Mar 2, 2017

cmsbuild added comparison-pending dqm-pending l1-pending orp-pending pending-signatures tests-pending labels Mar 2, 2017

Fix the missing configuration ReadPrescalesFromFile parameter in PATT…

1cc365e

…riggerProducer configuration file.

cmsbuild added analysis-pending reconstruction-pending labels Mar 26, 2017

cmsbuild added tests-started and removed tests-pending labels Mar 26, 2017

cmsbuild added tests-rejected and removed tests-started labels Mar 26, 2017

cmsbuild added comparison-available and removed comparison-pending labels Mar 26, 2017

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Apr 12, 2017

cmsbuild added l1-approved and removed l1-pending labels Apr 12, 2017

cmsbuild added tests-started and removed tests-pending labels Apr 12, 2017

cmsbuild added tests-approved and removed tests-started labels Apr 12, 2017

cmsbuild added comparison-available and removed comparison-pending labels Apr 12, 2017

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Apr 19, 2017

rekovic mentioned this pull request Apr 20, 2017

Pr91x l1t prescales from payloads rebased #18428

Merged

davidlange6 closed this Apr 22, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pr90x l1t prescales from payloads #17721

Pr90x l1t prescales from payloads #17721

cmsbuild commented Mar 2, 2017

cmsbuild commented Mar 2, 2017

cmsbuild commented Mar 26, 2017

rekovic commented Mar 26, 2017

rekovic commented Mar 26, 2017

cmsbuild commented Mar 26, 2017 •

edited

cmsbuild commented Mar 26, 2017

cmsbuild commented Mar 26, 2017

cmsbuild commented Mar 26, 2017

cmsbuild commented Apr 12, 2017

rekovic commented Apr 12, 2017

rekovic commented Apr 12, 2017

rekovic commented Apr 12, 2017

cmsbuild commented Apr 12, 2017 •

edited

cmsbuild commented Apr 12, 2017

cmsbuild commented Apr 12, 2017

cmsbuild commented Apr 12, 2017

rekovic commented Apr 14, 2017

rekovic commented Apr 14, 2017

perrotta commented Apr 19, 2017

davidlange6 commented Apr 19, 2017

rekovic commented Apr 20, 2017

dmitrijus commented Apr 21, 2017

Pr90x l1t prescales from payloads #17721

Pr90x l1t prescales from payloads #17721

Conversation

cmsbuild commented Mar 2, 2017

cmsbuild commented Mar 2, 2017

cmsbuild commented Mar 26, 2017

rekovic commented Mar 26, 2017

rekovic commented Mar 26, 2017

cmsbuild commented Mar 26, 2017 • edited

cmsbuild commented Mar 26, 2017

cmsbuild commented Mar 26, 2017

cmsbuild commented Mar 26, 2017

cmsbuild commented Apr 12, 2017

rekovic commented Apr 12, 2017

rekovic commented Apr 12, 2017

rekovic commented Apr 12, 2017

cmsbuild commented Apr 12, 2017 • edited

cmsbuild commented Apr 12, 2017

cmsbuild commented Apr 12, 2017

cmsbuild commented Apr 12, 2017

rekovic commented Apr 14, 2017

rekovic commented Apr 14, 2017

perrotta commented Apr 19, 2017

davidlange6 commented Apr 19, 2017

rekovic commented Apr 20, 2017

dmitrijus commented Apr 21, 2017

cmsbuild commented Mar 26, 2017 •

edited

cmsbuild commented Apr 12, 2017 •

edited