Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GEM validation #18690

Merged
merged 2 commits into from May 16, 2017
Merged

Fix GEM validation #18690

merged 2 commits into from May 16, 2017

Conversation

calabria
Copy link
Contributor

Fix the issue of the wrong paths used for some of the GEM validation plots.

@dmitrijus @kpedro88

Cesare Calabria added 2 commits May 11, 2017 13:19
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @calabria (Cesare Calabria) for CMSSW_9_1_X.

It involves the following packages:

Validation/MuonGEMDigis
Validation/MuonGEMHits
Validation/MuonGEMRecHits

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@dmitrijus
Copy link
Contributor

+1

fixes the issue found by #18562
backport of #18691

@cmsbuild
Copy link
Contributor

cmsbuild commented May 11, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19757/console Started: 2017/05/11 15:44

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_1_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_9_2_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18690/19757/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3359 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1830748
  • DQMHistoTests: Total failures: 48336
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1782232
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@dmitrijus
Copy link
Contributor

@calabria

Hi, you need to make a PR to master branch (9_2_X).

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a0ede53 into cms-sw:CMSSW_9_1_X May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants