Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a PFJets-Tau overlap removal module for HLT #18997

Merged
merged 9 commits into from
Jun 8, 2017
35 changes: 35 additions & 0 deletions RecoTauTag/HLTProducers/interface/PFJetsTauOverlapRemoval.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
#ifndef RecoTauTag_HLTProducers_PFJetsTauOverlapRemoval_H
#define RecoTauTag_HLTProducers_PFJetsTauOverlapRemoval_H

// user include files
#include "FWCore/Framework/interface/Frameworkfwd.h"
#include "FWCore/Framework/interface/global/EDProducer.h"
#include "FWCore/ParameterSet/interface/ConfigurationDescriptions.h"
#include "FWCore/ParameterSet/interface/ParameterSetDescription.h"
#include "FWCore/Framework/interface/Event.h"
#include "FWCore/ParameterSet/interface/ParameterSet.h"
#include "FWCore/Utilities/interface/InputTag.h"
#include "DataFormats/Common/interface/Handle.h"
#include "DataFormats/L1Trigger/interface/Tau.h"
#include "DataFormats/JetReco/interface/CaloJetCollection.h"
#include "DataFormats/TauReco/interface/PFTauFwd.h"
#include "DataFormats/HLTReco/interface/TriggerFilterObjectWithRefs.h"
#include "DataFormats/HLTReco/interface/TriggerObject.h"
#include "DataFormats/HLTReco/interface/TriggerEvent.h"

#include <map>
#include <vector>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the map or vector includes needed here? It doesn't seem so

class PFJetsTauOverlapRemoval: public edm::global::EDProducer<> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this not be a stream module?
@albertdow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, I haven't found anything that does exactly this..

public:
explicit PFJetsTauOverlapRemoval(const edm::ParameterSet&);
~PFJetsTauOverlapRemoval();
virtual void produce(edm::StreamID, edm::Event&, const edm::EventSetup&) const override;
static void fillDescriptions(edm::ConfigurationDescriptions& descriptions);

private:

const edm::EDGetTokenT<trigger::TriggerFilterObjectWithRefs> tauSrc_;
const edm::EDGetTokenT<reco::PFJetCollection> pfJetSrc_;
const double mindR_;
};
#endif
60 changes: 60 additions & 0 deletions RecoTauTag/HLTProducers/src/PFJetsTauOverlapRemoval.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
#include "RecoTauTag/HLTProducers/interface/PFJetsTauOverlapRemoval.h"
#include "Math/GenVector/VectorUtil.h"
#include "DataFormats/HLTReco/interface/TriggerTypeDefs.h"
#include "FWCore/Utilities/interface/EDMException.h"
#include "DataFormats/TauReco/interface/PFTau.h"

//
// class declaration
//
PFJetsTauOverlapRemoval::PFJetsTauOverlapRemoval(const edm::ParameterSet& iConfig):
tauSrc_ ( consumes<trigger::TriggerFilterObjectWithRefs>(iConfig.getParameter<edm::InputTag>("TauSrc" ) ) ),
pfJetSrc_ ( consumes<reco::PFJetCollection>(iConfig.getParameter<edm::InputTag>("PFJetSrc") ) ),
mindR_ ( iConfig.getParameter<double>("Min_dR") )
{
produces<reco::PFJetCollection>();
}
PFJetsTauOverlapRemoval::~PFJetsTauOverlapRemoval(){ }

void PFJetsTauOverlapRemoval::produce(edm::StreamID iSId, edm::Event& iEvent, const edm::EventSetup& iES) const
{

std::unique_ptr<reco::PFJetCollection> cleanedPFJets(new reco::PFJetCollection);

double matchingR2 = mindR_*mindR_;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to do this in the constructor


edm::Handle<trigger::TriggerFilterObjectWithRefs> tauJets;
iEvent.getByToken(tauSrc_, tauJets);

edm::Handle<reco::PFJetCollection> PFJets;
iEvent.getByToken(pfJetSrc_,PFJets);

trigger::VRpftau taus;
tauJets->getObjects(trigger::TriggerTau,taus);

if(PFJets->size() > 1){
for(unsigned int iJet = 0; iJet < 2; iJet++){
bool isMatched = false;
const reco::PFJet & myPFJet = (*PFJets)[iJet];
for(unsigned int iTau = 0; iTau < taus.size(); iTau++){
if(ROOT::Math::VectorUtil::DeltaR2((taus[iTau]->p4()).Vect(), myPFJet.p4().Vect()) < matchingR2){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still not reworked as suggested....

isMatched = true;
break;
}
}
if(isMatched == false) cleanedPFJets->push_back(myPFJet);
}
if(PFJets->size() > 2) cleanedPFJets->push_back((*PFJets)[2]);
}
iEvent.put(std::move(cleanedPFJets));
}

void PFJetsTauOverlapRemoval::fillDescriptions(edm::ConfigurationDescriptions& descriptions)
{
edm::ParameterSetDescription desc;
desc.add<edm::InputTag>("PFJetSrc", edm::InputTag("hltAK4PFJetsCorrected"))->setComment("Input collection of PFJets" );
desc.add<edm::InputTag>("TauSrc", edm::InputTag("hltPFTau20TrackLooseIso"))->setComment("Input collection of PFTaus that have passed ID and isolation requirements");
desc.add<double> ("Min_dR",0.5)->setComment("Minimum dR outside of which PFJets will be saved");
descriptions.setComment("This module produces a collection of PFJets that are cross-cleaned with respect to PFTaus passing a HLT filter.");
descriptions.add ("PFJetsTauOverlapRemoval",desc);
}
3 changes: 2 additions & 1 deletion RecoTauTag/HLTProducers/src/SealModule.cc
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
//#include "RecoTauTag/HLTProducers/interface/L2TauPixelTrackMatch.h"
#include "HLTPFTauPairLeadTrackDzMatchFilter.h"
#include "RecoTauTag/HLTProducers/interface/L2TauPixelIsoTagProducer.h"
#include "RecoTauTag/HLTProducers/interface/PFJetsTauOverlapRemoval.h"

DEFINE_EDM_PLUGIN(TrackingRegionProducerFactory, TauRegionalPixelSeedGenerator, "TauRegionalPixelSeedGenerator");
DEFINE_EDM_PLUGIN(TrackingRegionProducerFactory, TrackingRegionsFromBeamSpotAndL2Tau, "TrackingRegionsFromBeamSpotAndL2Tau");
Expand All @@ -45,4 +46,4 @@ DEFINE_FWK_MODULE(VertexFromTrackProducer);
//DEFINE_FWK_MODULE(L2TauPixelTrackMatch);
DEFINE_FWK_MODULE(HLTPFTauPairLeadTrackDzMatchFilter);
DEFINE_FWK_MODULE(L2TauPixelIsoTagProducer);

DEFINE_FWK_MODULE(PFJetsTauOverlapRemoval);