adding a PFJets-Tau overlap removal module for HLT #18997
Conversation
|
A new Pull Request was created by @albertdow for master. It involves the following packages: RecoTauTag/HLTProducers @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
|
||
| const edm::EDGetTokenT<trigger::TriggerFilterObjectWithRefs> tauSrc; | ||
| const edm::EDGetTokenT<reco::PFJetCollection> PFJetSrc; | ||
|
|
There was a problem hiding this comment.
Use a consistent convention for member data - eg, start with lowercase, append an underscore.
| } | ||
| } | ||
| else if(PFJets->size() == 3){ | ||
| for(unsigned int iTau = 0; iTau < taus.size(); iTau++){ |
There was a problem hiding this comment.
Why is a special case of 3 needed?
There was a problem hiding this comment.
hi Martin,
the general answer is this module is specific to the VBF seed and its corresponding HLT path (in development). The seed is such that it can have either 2 or 3 jets, and in case it selects 3 jets, we want to clean only those two that make up the larger m_jj.
I let Albert comment on the specific implementation though.
There was a problem hiding this comment.
Hi,
As Riccardo mentioned, there may be 2 or 3 jets of interest in the path. Using the first if statement (with condition PFJets->size() ==2) we cross-clean the 2 jets that make up the highest m_jj (finding these jets is done before by another module within the HLT path). However, if PFJets->size()==3 (else if statement) we again want to cross-clean the 2 jets with highest m_jj but also keep the 3rd jet which will have Pt>90 GeV (this is again decided by a previous module in the HLT path). Thus by adding this special case of PFJets->size()==3 this module can be used for both scenarios.
There was a problem hiding this comment.
But then the presence of a fourth jet switches from the second back to the first if case,
so any additional jet spoils this. That does not seem robust. Why should the
presence of a fourth jet change what you do with the first three jets?
| for(unsigned int iTau = 0; iTau < taus.size(); iTau++){ | ||
| for(unsigned int iJet = 0; iJet < PFJets->size(); iJet++){ | ||
| const PFJet & myPFJet = (*PFJets)[iJet]; | ||
| deltaR = ROOT::Math::VectorUtil::DeltaR((taus[iTau])->p4().Vect(), myPFJet.p4().Vect()); |
There was a problem hiding this comment.
Quoting David Lange: please use deltaR2 from DataFormats/Math/interface/deltaR unless some other functionality is intended
| for(unsigned int iTau = 0; iTau < taus.size(); iTau++){ | ||
| for(unsigned int iJet = 0; iJet < PFJets->size()-1; iJet++){ | ||
| const PFJet & myPFJet = (*PFJets)[iJet]; | ||
| deltaR = ROOT::Math::VectorUtil::DeltaR((taus[iTau])->p4().Vect(), myPFJet.p4().Vect()); |
There was a problem hiding this comment.
Quoting David Lange: please use deltaR2 from DataFormats/Math/interface/deltaR unless some other functionality is intended
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
No, a CaloJets-Tau overlap removal module will not be required. Overlap will always be removed between Taus and PFJets. |
|
Please make all the changes discussed in the PR #19068 also here (config parameters, deltaR2, include guard string, etc.) |
cmsbuild
added
comparison-pending
hlt-pending
pending-signatures
tests-pending
and removed
fully-signed
hlt-approved
tests-approved
labels
|
Pull request #18997 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
hlt-approved
and removed
hlt-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
+1 |
This module is able to remove the overlap between PF jets and taus. The PF jets would be taken from a PFJetCollection and the tau objects come from an HLT filter (so that we can use taus that are ID'ed and isolated). This is necessary for the development of VBF jets + tau HLT paths where we need to cross-clean the PF jets from taus.