adding an L1TCaloJetsMatching Module for HLT #19055
Conversation
|
A new Pull Request was created by @albertdow for master. It involves the following packages: RecoTauTag/HLTProducers @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| const edm::EDGetTokenT<trigger::TriggerFilterObjectWithRefs> jetTrigger_; | ||
| const double mPt1_Min; | ||
| const double mPt2_Min; | ||
| const double mMjj_Min; |
There was a problem hiding this comment.
please consistently follow coding rules, and give all member variable names ending with _ or starting with m_
| @@ -0,0 +1,35 @@ | |||
| #ifndef L1TCaloJetsMatching_H | |||
| #define L1TCaloJetsMatching_H | |||
There was a problem hiding this comment.
Please use
#ifndef RecoTauTag_HLTProducers_L1TCaloJetsMatching_h
#define RecoTauTag_HLTProducers_L1TCaloJetsMatching_h|
|
||
| void L1TCaloJetsMatching::produce(edm::StreamID iSId, edm::Event& iEvent, const edm::EventSetup& iES) const | ||
| { | ||
| std::unique_ptr<reco::CaloJetCollection> caloMatchedJets(new reco::CaloJetCollection); |
There was a problem hiding this comment.
just a suggestion: use
auto caloMatchedJets = std::make_unique<reco::CaloJetCollection>();There was a problem hiding this comment.
actually, you do not put this in the Event, so you should simply use a local variable
reco::CaloJetCollection caloMatchedJets;
| deltaR2 = ROOT::Math::VectorUtil::DeltaR2(myJet.p4().Vect(), (jetCandRefVec[iL1Jet]->p4()).Vect()); | ||
| if(deltaR2 < matchingR2 ) { | ||
| caloMatchedJets->push_back(myJet); | ||
| break; |
There was a problem hiding this comment.
You are looking for any one matching pair, not the closest ?
|
|
||
| std::pair<reco::CaloJetCollection,reco::CaloJetCollection> pairJets = categorise(*caloMatchedJets, mPt1_Min, mPt2_Min, mMjj_Min); | ||
| std::unique_ptr<reco::CaloJetCollection> twoJets(new reco::CaloJetCollection(pairJets.first)); | ||
| std::unique_ptr<reco::CaloJetCollection> threeJets(new reco::CaloJetCollection(pairJets.second)); |
There was a problem hiding this comment.
auto twoJets = std::make_unique<reco::CaloJetCollection>(pairJets.first);
auto threeJets = std::make_unique<reco::CaloJetCollection>(pairJets.second);
|
This looks like a duplication of #18992 for a different collection type (Calo vs PF). |
|
-1 |
|
Moved to #19068 |
This module is able to match a collection of CaloJets to L1 jets and then sort the matched CaloJets into collections of either two or three jets, depending on certain Pt and mJJ requirements. This module is required for the development of VBF + Tau HLT paths.