Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[92X] Adding the DQMEventInfo module in SiStripGains and SiPixelAli PCL sequences #19385

Merged
merged 1 commit into from Jun 24, 2017

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 20, 2017

Greetings,
this PR aims to provide to the harvested ALCAPROMPT files for the SiStripGains and SiPixelAli Prompt Calibration Loop flavours, the necessary input histograms to show the run/ LS / start time info to be displayed in the DQM GUI header, as it is done for the standard DQM.
Special thanks to @threus for guidance in solving the issue.

@franzoni @arunhep, there are probably other flavours of the PCL applications that might benefit from the same update. I've done it only for the ones I am most familiar with. Also the changes fall in the AlCa area, but it would be wise to assign dqm category as reviewers as well.

The changes have been tested via runTheMatrix.py -l 1001.0 and the output harvested files have been uploaded to a local development GUI.
I am attaching here the results of the test:

  • SiStripGainsAAG:

screenshot 2017-06-20 18 36 57

  • SiStripGains:

screenshot 2017-06-20 18 37 20

  • SiPixelAli:

screenshot 2017-06-20 18 37 40

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Alignment/CommonAlignmentProducer
Calibration/TkAlCaRecoProducers

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @tocheng, @tlampen, @mschrode, @mmusich, @threus this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@arunhep
Copy link
Contributor

arunhep commented Jun 20, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 20, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20794/console Started: 2017/06/20 20:21

@arunhep
Copy link
Contributor

arunhep commented Jun 20, 2017

assign dqm

@cmsbuild
Copy link
Contributor

New categories assigned: dqm

@vanbesien,@vazzolini,@kmaeshima,@dmitrijus you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19385/20794/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1803260
  • DQMHistoTests: Total failures: 29850
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1773244
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@arunhep
Copy link
Contributor

arunhep commented Jun 21, 2017

+1

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants