[93X] Adding the DQMEventInfo module to the SiStrip Bad components harvesting

[mmusich]

Greetings,
this PR aims to provide to the harvested ALCAPROMPT files for the SiStrip bad components flavour the necessary input histograms to show the run/ LS / start time info to be displayed in the DQM GUI header, as it is done for the standard DQM - in the same spirit of #19385

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Calibration/TkAlCaRecoProducers

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @threus, @tocheng this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22173/console Started: 2017/08/09 17:59

[cmsbuild]

+1
Tested at: 6d989e7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20097/22173/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
5d342d6
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20097/22173/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20097/22173/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20097/22173/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-20097/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+ALCAFull_2019+HARVESTFull_2019

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2868181
• DQMHistoTests: Total failures: 884
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2867108
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[arunhep]

strange that I see differences in wf10024.0 and also in others https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_9_3_X_2017-08-09-1100+20097/21869/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/EcalBarrel.html

[mmusich]

Hi @arunhep,
strange indeed. As far as I know AlcaSiStripQualityHarvester should not even be in any sequence run in wf. 10024.0 - as a matter of fact the only wf in which I expect changes is 1001.0, i.e. the one in which there is an harvesting of the Strip bad components.
Might be the commit 5d342d6, pulled in by the merge-topic is responsible for the changes? Also the comparison doesn't seem to be totally clean (see #20097 (comment)).
I want to mention that the same wf in the equivalent backport PR in 92X #20098 doesn't show any unexpected difference.
All in all looks safe to me to proceed with this (minor) convenience change - if you have doubts you might want to re-trigger the tests to get a clean comparison. Thanks

[mmusich]

@arunhep @lpernie, what is blocking this PR?

[franzoni]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1