Eras for HCAL hardcode conditions and packer skipping

[kpedro88]

There have been a number of "solutions" for enabling HCAL hardcode conditions and avoiding the packer/unpacker (customization functions, phase2-specific Era modifications, EDAliases, etc.). None of these were general enough to be completely satisfactory.

This PR introduces two general-use Eras:

1. hcalHardcodeConditions, which enables the use of HCAL hardcoded conditions. The subdetector-specific settings for HcalHardcodeCalibrations are now enabled with the relevant Eras, so they will be consistently set for any simulation scenario.
2. hcalSkipPacker, which skips the packer and runs the new fake unpacker HcalRawToDigiFake. This fake unpacker just duplicates the simulated digi collections as hcalDigis collections, in order to avoid changing any InputTags.

Typically, hcalSkipPacker should be used when hcalHardcodeConditions is used, unless a real ElectronicsMap is used (rather than the hardcoded one, which is not appropriate for packing). Both of these Eras are now used for Phase2, and will be used for the upcoming Run3 workflow. They can also be manually chained with any other Era to enable the hardcode conditions and/or skip packing, in case such behavior is needed by a user.

HCalCustoms.py is deleted, since it is no longer needed for any purpose.

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

CalibCalorimetry/HcalPlugins
Configuration/Eras
Configuration/EventContent
Configuration/Geometry
Configuration/StandardSequences
EventFilter/HcalRawToDigi
RecoLocalCalo/Configuration
SLHCUpgradeSimulations/Configuration

@perrotta, @ghellwig, @civanch, @Dr15Jones, @arunhep, @ianna, @mdhildreth, @cmsbuild, @franzoni, @kpedro88, @cerminar, @slava77, @davidlange6, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @sviret, @GiacomoSguazzoni, @tocheng, @VinInn, @Martin-Grunewald, @rovere, @ebrondol, @mmusich, @dgulhan this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21410/console Started: 2017/07/12 20:41

[kpedro88]

please hold
need to address one more compatibility issue

[cmsbuild]

+1
Tested at: a242592
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19712/21410/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
de56eaa
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19712/21410/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19712/21410/git-merge-result

[kpedro88]

please test

[kpedro88]

unhold

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21417/console Started: 2017/07/12 22:40

[cmsbuild]

Pull request #19712 was updated. @perrotta, @ghellwig, @civanch, @Dr15Jones, @arunhep, @ianna, @mdhildreth, @cmsbuild, @franzoni, @kpedro88, @cerminar, @slava77, @davidlange6, @lpernie can you please check and sign again.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19712/21417/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 2015567
• DQMHistoTests: Total failures: 14518
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2000883
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 93 log files, 14 edm output root files, 23 DQM output files

[kpedro88]

+1

[kpedro88]

@franzoni @ianna @perrotta @slava77 @civanch @mdhildreth please review/sign ASAP, this is needed for the Run3 workflow also (PR pending)

[ianna]

+1

[perrotta]

You removed
SLHCUpgradeSimulations/Configuration/python/HCalCustoms.py
but it is still looked for inside
SLHCUpgradeSimulations/Configuration/python/combinedCustoms.py

[kpedro88]

@perrotta combinedCustoms isn't actually used anymore, but your point is taken. I'll prepare a separate PR removing it entirely (a few test configs still reference it).

[kpedro88]

@perrotta see #19748

[perrotta]

+1

• Reorganization of HCAL eras for run2 and run3
• At the end, the actual run2 and run3 HB,HE,HF customizations remain the same as now
• As such, no differences are expected in standard workflows, and no differences are visible in jenkins tests
• combinedCustoms is currently only linked by some (outdated, I guess...) HGCal validation test, and it will be fully removed by remove combinedCustoms entirely #19748

[civanch]

+1

[kpedro88]

@ghellwig, @arunhep, @franzoni, @cerminar, @lpernie please take a look - only change for AlCa is reorganization of Era usage in Hcal_Conditions_forGlobalTag_cff.py

[arunhep]

+1

[kpedro88]

@davidlange6 ping

[davidlange6]

merge