remove combinedCustoms entirely

[kpedro88]

SLHCUpgradeSimulations.Configuration.combinedCustoms is no longer used or maintained, and has gradually become out of sync with python dependencies. This PR removes all references to it.

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

L1Trigger/L1THGCal
RecoMuon/MuonIdentification
SLHCUpgradeSimulations/Configuration
Validation/HGCalValidation

@perrotta, @civanch, @vazzolini, @kmaeshima, @mdhildreth, @dmitrijus, @cmsbuild, @rekovic, @kpedro88, @slava77, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@abbiendi, @sviret, @Martin-Grunewald, @bsunanda, @pfs, @kreczko, @sethzenz, @battibass, @makortel, @jhgoh, @lgray, @HuguesBrun, @trocino, @rociovilar, @vandreev11, @cseez, @bellan, @ebrondol, @echapon, @calderona, @amarini, @bachtis, @jbsauvan this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21481/console Started: 2017/07/14 17:50

[dmitrijus]

+1

[cmsbuild]

+1
Tested at: 2568631
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19748/21481/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2136e02
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19748/21481/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19748/21481/git-merge-result

[cmsbuild]

Comparison job queued.

[kpedro88]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19748/21481/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 2022761
• DQMHistoTests: Total failures: 14925
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2007670
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 93 log files, 14 edm output root files, 23 DQM output files

[perrotta]

+1

• combinedCustoms is currently only linked by some outdated HGCal validation test, also cleaned here
• when merged Eras for HCAL hardcode conditions and packer skipping #19712, combinedCustoms will also have broken python dependencies
• no changes in jenkins test, as expected

[slava77]

On 7/14/17 5:27 PM, perrotta wrote: +1 * combinedCustoms is currently only linked by some outdated HGCal validation test, also cleaned here * when merged #19712 <#19712>, combinedCustoms will also have broken python dependencies

does it mean that this PR has to go in first? .. or that 19712 is incomplete and should wait

…

* no changes in jenkins test, as expected — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19748 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdcbob2va1Lu3hWh6wo74CvZzZEuJ5Lks5sN91TgaJpZM4OYRhp>.

[perrotta]

#19712 removes the file which is linked in combinedCustoms:
from SLHCUpgradeSimulations.Configuration.HCalCustoms import customise_HcalPhase1, customise_HcalPhase0

Therefore combinedCustoms will remain with broken dependencies, and it has to be either fixed or removed. Since it "is no longer used or maintained", the solution here is to remove that file and all dependencies to it (that were either commented out, or in unused or unmaintained test scripts)

In any case, even if #19712 is merged first, SLHCUpgradeSimulations.Configuration should build without errors: therefore the order may be irrelevant.