Add in CCE degradation and add HGCal to aging customizations #19896

lgray · 2017-07-25T12:04:31Z

This PR implements the charge collection efficiency degradation expected after irradiation of silicon.
The the deposited charged is now degraded in addition to the increase in the electronics noise.

There is an option to follow the value of the MIP (which changes as the CCE degrades) with the thresholds for the digitizer. Presently it is set to false.

This PR also fixes an issue with saturation where saturated rechits were reading as zero energy.

lgray · 2017-07-25T12:04:40Z

@cmsbuild please test

cmsbuild · 2017-07-25T12:05:01Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21731/console Started: 2017/07/25 14:08

cmsbuild · 2017-07-25T12:05:02Z

A new Pull Request was created by @lgray (Lindsey Gray) for master.

It involves the following packages:

DataFormats/HGCDigi
SLHCUpgradeSimulations/Configuration
SimCalorimetry/HGCalSimProducers

@cmsbuild, @civanch, @mdhildreth, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@cseez, @vandreev11, @sethzenz, @makortel, @sviret, @Martin-Grunewald, @pfs, @ebrondol, @kpedro88 this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2017-07-25T13:52:19Z

+1
Tested at: dc10ea0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19896/21731/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
3b3a9c0
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19896/21731/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19896/21731/git-merge-result

cmsbuild · 2017-07-25T13:52:22Z

Comparison job queued.

kpedro88 · 2017-07-25T14:51:17Z

SLHCUpgradeSimulations/Configuration/python/aging.py

    return process

 def customise_aging_3000_ultimate(process):
    process=ageHcal(process,3000,7.5e34,"ultimate")
    process=ageEcal(process,3000,7.5e34)
+    process=agedHGCal(process)


the aging model doesn't depend at all on the luminosity?

@lgray still curious about this...

Right now I only have two data points and no indication of how they scale, if there's saturation of any effects, etc.

kpedro88 · 2017-07-25T14:52:32Z

@lgray is there an example of how the aging affects physics distributions? (e.g. jet response)

cmsbuild · 2017-07-25T21:24:42Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19896/21731/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 2355459
DQMHistoTests: Total failures: 29997
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2325296
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 93 log files, 14 edm output root files, 23 DQM output files

lgray · 2017-07-26T08:40:30Z

@kpedro88 Nominally it should cause an increase in photon/jet energy resolution, once the rechits are recalibrated to adjust for the change in scale. There may be some minor change in the jet energy scale as well, depending on how the thresholds are managed. I'll add the corresponding change to the rechit energy scale so that this will hold true. Update in a moment.

…

On Tue, Jul 25, 2017 at 4:24 PM, cmsbuild ***@***.***> wrote: Comparison is ready https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull- request-integration/PR-19896/21731/summary.html Comparison Summary: - No significant changes to the logs found - Reco comparison results: 0 differences found in the comparisons - DQMHistoTests: Total files compared: 23 - DQMHistoTests: Total histograms compared: 2355459 - DQMHistoTests: Total failures: 29997 - DQMHistoTests: Total nulls: 0 - DQMHistoTests: Total successes: 2325296 - DQMHistoTests: Total skipped: 166 - DQMHistoTests: Total Missing objects: 0 - Checked 93 log files, 14 edm output root files, 23 DQM output files — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19896 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABBMOSbuY1xxHZxvp3J6CP2Oyc2X4KNaks5sRl0cgaJpZM4Oida2> .

cmsbuild · 2017-07-26T14:11:00Z

Pull request #19896 was updated. @perrotta, @civanch, @mdhildreth, @cmsbuild, @kpedro88, @slava77, @davidlange6 can you please check and sign again.

lgray · 2017-07-26T14:11:48Z

@cmsbuild please test

cmsbuild · 2017-07-26T14:12:04Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21786/console Started: 2017/07/26 16:12

cmsbuild · 2017-09-01T19:40:01Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-09-01T19:40:02Z

Pull request #19896 was updated. @perrotta, @civanch, @mdhildreth, @cmsbuild, @kpedro88, @slava77 can you please check and sign again.

lgray · 2017-09-01T19:40:32Z

@perrotta

fixed the SA warning
The CCE is not corrected for in the digitization (where less charge is accumulated when CCE < 1), therefore it should be corrected for in the RecHits to have a consistent energy.

lgray · 2017-09-01T19:40:39Z

@cmsbuild please test

cmsbuild · 2017-09-01T19:40:49Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22660/console Started: 2017/09/01 21:41

cmsbuild · 2017-09-01T19:41:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-19896/456

cmsbuild · 2017-09-01T21:50:56Z

+1
Tested at: ba14747
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19896/22660/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
91fd772
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19896/22660/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19896/22660/git-merge-result

cmsbuild · 2017-09-01T21:50:59Z

Comparison job queued.

cmsbuild · 2017-09-01T22:44:07Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19896/22660/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 18 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2656222
DQMHistoTests: Total failures: 206
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2655827
DQMHistoTests: Total skipped: 189
DQMHistoTests: Total Missing objects: 0
Checked 107 log files, 14 edm output root files, 26 DQM output files

kpedro88 · 2017-09-04T20:09:20Z

+1

perrotta · 2017-09-06T07:36:56Z

+1

The code applies correction factors for CCE degradation in recHits identical to what used in simulated digis, plus a fix for the saturated hits; the most of this PR is relevant for Simulation.
The implementation looks correct, also following the explanations provided in the discussion
The degraded detector is not included in the standard phaseII workflows by now, and therefore it couldn't be tested detailedly. Some validation plot which validates the corrections applied was asked to the authors: since Felice is apparently still in vacation, it looks like those plots will not arrive that early anyhow.
In order to speed up the integration, I decided to sign this PR for reco anyhow: it is intended that the authors will update the calibrations in it in case the results of the validation of the degraded detector will require so.
In any case, the default configuration is only touched by the fix for the saturated hits, which only marginally propagates to the final outputs, e.g wf20434:

kpedro88 · 2017-09-06T15:21:45Z

@civanch @mdhildreth please sign

davidlange6 · 2017-09-06T15:54:27Z

merge

cmsbuild added this to the CMSSW_9_3_X milestone Jul 25, 2017

cmsbuild added comparison-pending orp-pending pending-signatures simulation-pending tests-pending upgrade-pending labels Jul 25, 2017

cmsbuild added tests-started and removed tests-pending labels Jul 25, 2017

cmsbuild added tests-approved and removed tests-started labels Jul 25, 2017

kpedro88 reviewed Jul 25, 2017

View reviewed changes

cmsbuild added comparison-available and removed comparison-pending labels Jul 25, 2017

cmsbuild added comparison-pending reconstruction-pending tests-pending and removed comparison-available tests-approved labels Jul 26, 2017

cmsbuild added the tests-pending label Sep 1, 2017

cmsbuild added tests-started and removed tests-pending labels Sep 1, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 1, 2017

cmsbuild added tests-approved and removed tests-started labels Sep 1, 2017

cmsbuild added comparison-available and removed comparison-pending labels Sep 1, 2017

cmsbuild added upgrade-approved and removed upgrade-pending labels Sep 4, 2017

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Sep 6, 2017

smuzaffar modified the milestones: CMSSW_9_4_X, CMSSW_9_3_X Sep 6, 2017

cmsbuild merged commit 43b3b13 into cms-sw:master Sep 6, 2017

kpedro88 mentioned this pull request Sep 6, 2017

Add in CCE degradation and add HGCal to aging customizations [93X] #20408

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add in CCE degradation and add HGCal to aging customizations #19896

Add in CCE degradation and add HGCal to aging customizations #19896

lgray commented Jul 25, 2017

lgray commented Jul 25, 2017

cmsbuild commented Jul 25, 2017 •

edited

cmsbuild commented Jul 25, 2017

cmsbuild commented Jul 25, 2017

cmsbuild commented Jul 25, 2017

kpedro88 Jul 25, 2017

kpedro88 Jul 27, 2017

lgray Jul 27, 2017

kpedro88 commented Jul 25, 2017

cmsbuild commented Jul 25, 2017

lgray commented Jul 26, 2017 via email

cmsbuild commented Jul 26, 2017

lgray commented Jul 26, 2017

cmsbuild commented Jul 26, 2017 •

edited

cmsbuild commented Sep 1, 2017

cmsbuild commented Sep 1, 2017

lgray commented Sep 1, 2017

lgray commented Sep 1, 2017

cmsbuild commented Sep 1, 2017 •

edited

cmsbuild commented Sep 1, 2017

cmsbuild commented Sep 1, 2017

cmsbuild commented Sep 1, 2017

cmsbuild commented Sep 1, 2017

kpedro88 commented Sep 4, 2017

perrotta commented Sep 6, 2017

kpedro88 commented Sep 6, 2017

davidlange6 commented Sep 6, 2017

Add in CCE degradation and add HGCal to aging customizations #19896

Add in CCE degradation and add HGCal to aging customizations #19896

Conversation

lgray commented Jul 25, 2017

lgray commented Jul 25, 2017

cmsbuild commented Jul 25, 2017 • edited

cmsbuild commented Jul 25, 2017

cmsbuild commented Jul 25, 2017

cmsbuild commented Jul 25, 2017

kpedro88 Jul 25, 2017

Choose a reason for hiding this comment

kpedro88 Jul 27, 2017

Choose a reason for hiding this comment

lgray Jul 27, 2017

Choose a reason for hiding this comment

kpedro88 commented Jul 25, 2017

cmsbuild commented Jul 25, 2017

lgray commented Jul 26, 2017 via email

cmsbuild commented Jul 26, 2017

lgray commented Jul 26, 2017

cmsbuild commented Jul 26, 2017 • edited

cmsbuild commented Sep 1, 2017

cmsbuild commented Sep 1, 2017

lgray commented Sep 1, 2017

lgray commented Sep 1, 2017

cmsbuild commented Sep 1, 2017 • edited

cmsbuild commented Sep 1, 2017

cmsbuild commented Sep 1, 2017

cmsbuild commented Sep 1, 2017

cmsbuild commented Sep 1, 2017

kpedro88 commented Sep 4, 2017

perrotta commented Sep 6, 2017

kpedro88 commented Sep 6, 2017

davidlange6 commented Sep 6, 2017

cmsbuild commented Jul 25, 2017 •

edited

cmsbuild commented Jul 26, 2017 •

edited

cmsbuild commented Sep 1, 2017 •

edited