Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in CCE degradation and add HGCal to aging customizations [93X] #20408

Merged
merged 8 commits into from Sep 12, 2017

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Sep 6, 2017

Backport of #19896

@kpedro88 kpedro88 changed the title Add in CCE degradation and add HGCal to aging customizations [92X] Add in CCE degradation and add HGCal to aging customizations [93X] Sep 6, 2017
@cmsbuild cmsbuild added this to the CMSSW_9_3_X milestone Sep 6, 2017
@kpedro88
Copy link
Contributor Author

kpedro88 commented Sep 6, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22759/console Started: 2017/09/06 18:39

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_9_3_X.

It involves the following packages:

DataFormats/HGCDigi
RecoLocalCalo/HGCalRecProducers
SLHCUpgradeSimulations/Configuration
SimCalorimetry/HGCalSimProducers

@perrotta, @civanch, @mdhildreth, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @vandreev11, @edjtscott, @sethzenz, @makortel, @felicepantaleo, @sviret, @lgray, @cseez, @pfs, @ebrondol this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20408/22759/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 18 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2656498
  • DQMHistoTests: Total failures: 198
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2656111
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@kpedro88
Copy link
Contributor Author

kpedro88 commented Sep 6, 2017

+1

@perrotta
Copy link
Contributor

perrotta commented Sep 7, 2017

#19896 is already included in the latest 93X IB (CMSSW_9_3_X_2017-09-06-2300); therefore this backport can be closed.

@perrotta
Copy link
Contributor

perrotta commented Sep 7, 2017

Wait Kevin: there is an ongoing discussion in #20407 (comment)

@kpedro88 kpedro88 reopened this Sep 7, 2017
@perrotta
Copy link
Contributor

perrotta commented Sep 8, 2017

+1
Identical to #19896, already merged in the master

@civanch
Copy link
Contributor

civanch commented Sep 8, 2017

+1
there are few minor questions: I would guess std::end is not needed in LogInfo; float const should be always float an dont double. Because this PR has been already merged to 9_4, probably optimal merge it to 9_3 too.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 43c4044 into cms-sw:CMSSW_9_3_X Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants