Enable HLT DQM for MET plus Track EXO triggers #19946
Conversation
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages: DQMOffline/Trigger @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
hi @fwyzard - coming back to this - I seem to have been wrong about my review of this - presumably it means there is something else that needs review but my notes currently fail me - anyway, this code only has the same buggy plots vs LS that I presume someone is looking into? |
|
ciao
uhmm, sorry for jumping on this only now .. but .....
can you comment on "buggy plots vs LS that I presume someone is looking
into" ?
it sounds new to me :(
thanks
…On Mon, Jul 31, 2017 at 4:40 PM, David Lange ***@***.***> wrote:
hi @fwyzard <https://github.com/fwyzard> - coming back to this - I seem
to have been wrong about my review of this - presumably it means there is
something else that needs review but my notes currently fail me - anyway,
this code only has the same buggy plots vs LS that I presume someone is
looking into?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19946 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt584nKE1eBba9S6Gj3vKsdPlz7m_uSks5sTedFgaJpZM4OmayO>
.
|
|
Well, @davidlange6 you had comments about the code, but they were addressed, and then I passed it though clang-tidy that probably fixed other non-optimal constructs. @mtosi, see the discussion in #19794 . .A |
|
thanks
…On Mon, Jul 31, 2017 at 5:17 PM, Andrea Bocci ***@***.***> wrote:
Well, @davidlange6 <https://github.com/davidlange6> you had comments
about the code, but they were addressed, and then I passed it though
clang-tidy that probably fixed other non-optimal constructs.
@mtosi <https://github.com/mtosi>, see the discussion in #19794
<#19794> .
.A
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19946 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt583ds3oF6mT07bqN-7qclYou6kq7gks5sTfADgaJpZM4OmayO>
.
|
|
@davidlange6 , if you do not have any further comments on the code, could you merge this PR ? |
|
@cmsbuild, please test |
|
@davidlange6 Can we please proceed with this PR? |
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-pending
tests-started
and removed
tests-started
tests-pending
labels
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
merge |
Re-enable the HLT DQM developed at #19490, which is currently disabled pending a review of the METplusTrackMonitor.h / .cc code.