New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the HGCAL-Seeded ElectronSeed collection to the FEVT and RECO event contents. #20368
Add the HGCAL-Seeded ElectronSeed collection to the FEVT and RECO event contents. #20368
Conversation
The code-checks are being triggered in jenkins. |
A new Pull Request was created by @archiron (Chiron) for master. It involves the following packages: TrackingTools/Configuration @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks |
@archiron |
@@ -12,6 +13,7 @@ | |||
outputCommands = cms.untracked.vstring('keep *_CkfElectronCandidates_*_*', | |||
'keep *_GsfGlobalElectronTest_*_*', | |||
'keep *_electronMergedSeeds_*_*', | |||
'keep *_electronMergedSeedsFromMultiCl_*_*', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the phase-2 specific products should be added below with the era modifiers
@archiron |
assign upgrade |
New categories assigned: upgrade @kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks |
The code-checks are being triggered in jenkins. |
+code-checks |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
The size of the collection for ZEE events with 200 PU is 163336 bytes/event to be compared with 635668 for the default collection. |
Comparison is ready Comparison Summary:
|
+1 |
@perrotta is this acceptable now? |
It would make our life in validation much much easier. |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@archiron please make a backport PR to the 93X branch ASAP (you can reuse your same branch) |
actually in the interest of time, I'll just do it |
when is the next 93X build? |
Not up to me - whenever HGCal needs it, hopefully. |
Fix for the missing electronMergedSeedsFromMultiCl collection in the RECO and FEVT event content.
This collection contains the track seeds for the HGCAL-seeds electrons and is needed to run the electron MC validation.
The size is of the "new" collection is about 2901 bytes/event vs 4490 for the default seed collection (determined in ZEE events w/o PU).
@rovere @beaudett