Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the HGCAL-Seeded ElectronSeed collection to the FEVT and RECO event contents. #20368

Merged
merged 5 commits into from Sep 6, 2017
Merged

Add the HGCAL-Seeded ElectronSeed collection to the FEVT and RECO event contents. #20368

merged 5 commits into from Sep 6, 2017

Conversation

archiron
Copy link
Contributor

@archiron archiron commented Sep 4, 2017

Fix for the missing electronMergedSeedsFromMultiCl collection in the RECO and FEVT event content.
This collection contains the track seeds for the HGCAL-seeds electrons and is needed to run the electron MC validation.
The size is of the "new" collection is about 2901 bytes/event vs 4490 for the default seed collection (determined in ZEE events w/o PU).

@rovere @beaudett

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

A new Pull Request was created by @archiron (Chiron) for master.

It involves the following packages:

TrackingTools/Configuration

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20368/486

@slava77
Copy link
Contributor

slava77 commented Sep 4, 2017

@archiron
please change the title of this PR to be grammatically correct and descriptive.
Thank you.

@@ -12,6 +13,7 @@
outputCommands = cms.untracked.vstring('keep *_CkfElectronCandidates_*_*',
'keep *_GsfGlobalElectronTest_*_*',
'keep *_electronMergedSeeds_*_*',
'keep *_electronMergedSeedsFromMultiCl_*_*',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the phase-2 specific products should be added below with the era modifiers

@slava77
Copy link
Contributor

slava77 commented Sep 4, 2017

@archiron
please provide size estimates with PU200

@slava77
Copy link
Contributor

slava77 commented Sep 4, 2017

assign upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

@archiron archiron changed the title Track hgcal seeds multi cl 93 x v3 Fixing electronMergedSeedsFromMultiCl in the RECO and FEVT event content Sep 4, 2017
@archiron archiron changed the title Fixing electronMergedSeedsFromMultiCl in the RECO and FEVT event content Add the HGCAL-Seeded ElectronSeed collection to the FEVT and RECO event contents. Sep 4, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

Pull request #20368 was updated. @perrotta, @cmsbuild, @kpedro88, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20368/491

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

Comparison job queued.

@archiron
Copy link
Contributor Author

archiron commented Sep 5, 2017

The size of the collection for ZEE events with 200 PU is 163336 bytes/event to be compared with 635668 for the default collection.
recoElectronSeeds_electronMergedSeedsFromMultiCl__RECO. 1.10364e+06 163336
recoElectronSeeds_electronMergedSeeds__RECO. 4.79445e+06 635668

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20368/22707/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2656434
  • DQMHistoTests: Total failures: 201
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2656044
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Sep 6, 2017

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Sep 6, 2017

@perrotta is this acceptable now?

@rovere
Copy link
Contributor

rovere commented Sep 6, 2017

It would make our life in validation much much easier.

@slava77
Copy link
Contributor

slava77 commented Sep 6, 2017

+1

for #20368 b6657cf

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b8310a4 into cms-sw:master Sep 6, 2017
@kpedro88
Copy link
Contributor

kpedro88 commented Sep 6, 2017

@archiron please make a backport PR to the 93X branch ASAP (you can reuse your same branch)

@kpedro88
Copy link
Contributor

kpedro88 commented Sep 6, 2017

actually in the interest of time, I'll just do it

@slava77
Copy link
Contributor

slava77 commented Sep 6, 2017

actually in the interest of time, I'll just do it

when is the next 93X build?

@kpedro88
Copy link
Contributor

kpedro88 commented Sep 6, 2017

Not up to me - whenever HGCal needs it, hopefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants