-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the HGCAL-Seeded ElectronSeed collection to the FEVT and RECO event contents. [93X] #20407
Add the HGCAL-Seeded ElectronSeed collection to the FEVT and RECO event contents. [93X] #20407
Conversation
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_9_3_X. It involves the following packages: TrackingTools/Configuration @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
assign upgrade |
New categories assigned: upgrade @kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
#20368 is already included in the latest 93X IB (CMSSW_9_3_X_2017-09-06-2300); therefore this backport can be closed. |
that PR is also in CMSSW_9_4_X_2017-09-06-2300 |
CMSSW_9_3_X_2017-09-06-1100...CMSSW_9_3_X_2017-09-06-2300 |
but I do not see the changes here in https://github.com/cms-sw/cmssw/commits/CMSSW_9_3_X/TrackingTools/Configuration/python/TrackingTools_EventContent_cff.py. Ah my bad, 93X is still using master branch to tag. I am fixing it and re-building 93X IB now. |
@smuzaffar does this mean this PR should be closed or not? What about #20408? |
@kpedro88 , no both of these should remain open if they are meant for 93X (they are not in 93X yet). I will check if I can fix showIB to ignore 93X 06-1100 and 06-2300 IBs to get the correct PRs list which went in to 93X |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Backport of #20368