Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the HGCAL-Seeded ElectronSeed collection to the FEVT and RECO event contents. [93X] #20407

Merged
merged 5 commits into from
Sep 12, 2017
Merged

Add the HGCAL-Seeded ElectronSeed collection to the FEVT and RECO event contents. [93X] #20407

merged 5 commits into from
Sep 12, 2017

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Sep 6, 2017

Backport of #20368

@kpedro88
Copy link
Contributor Author

kpedro88 commented Sep 6, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22758/console Started: 2017/09/06 18:25

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_9_3_X.

It involves the following packages:

TrackingTools/Configuration

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

kpedro88 commented Sep 6, 2017

assign upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20407/22758/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2656498
  • DQMHistoTests: Total failures: 207
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2656102
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@kpedro88
Copy link
Contributor Author

kpedro88 commented Sep 6, 2017

+1

@perrotta
Copy link
Contributor

perrotta commented Sep 7, 2017

#20368 is already included in the latest 93X IB (CMSSW_9_3_X_2017-09-06-2300); therefore this backport can be closed.

@slava77
Copy link
Contributor

slava77 commented Sep 7, 2017

#20368 is already included in the latest 93X

that PR is also in CMSSW_9_4_X_2017-09-06-2300
@smuzaffar @davidlange6
Was it an intended behavior for just one IB, or will it continue for more?

@smuzaffar
Copy link
Contributor

@slava77 , @perrotta #20368 is only in 94X. Looks like there is bug in the script which generate the IB pages that is why it is showing that #20368 is psrt of 93X. I will check this tomorrow.

@slava77
Copy link
Contributor

slava77 commented Sep 7, 2017

CMSSW_9_3_X_2017-09-06-1100...CMSSW_9_3_X_2017-09-06-2300
shows that #20368 is in CMSSW_9_3_X_2017-09-06-2300.
So, I don't think it's the showIB to blame.

@smuzaffar
Copy link
Contributor

but I do not see the changes here in https://github.com/cms-sw/cmssw/commits/CMSSW_9_3_X/TrackingTools/Configuration/python/TrackingTools_EventContent_cff.py.

Ah my bad, 93X is still using master branch to tag. I am fixing it and re-building 93X IB now.

@kpedro88
Copy link
Contributor Author

kpedro88 commented Sep 7, 2017

@smuzaffar does this mean this PR should be closed or not? What about #20408?

@smuzaffar
Copy link
Contributor

@kpedro88 , no both of these should remain open if they are meant for 93X (they are not in 93X yet). I will check if I can fix showIB to ignore 93X 06-1100 and 06-2300 IBs to get the correct PRs list which went in to 93X

@perrotta
Copy link
Contributor

perrotta commented Sep 8, 2017

+1
Identical to #20368, merged in 93X

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 58773ac into cms-sw:CMSSW_9_3_X Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants