Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecal pedestal pcl fixes 93x #20399

Merged
merged 9 commits into from
Sep 12, 2017

Conversation

argiro
Copy link
Contributor

@argiro argiro commented Sep 6, 2017

fix for Nans, added histos, added check, added exclusion of non-stable beam (off in config)
Same as #20366 (based on master) , but for 93x

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

A new Pull Request was created by @argiro for CMSSW_9_3_X.

It involves the following packages:

Calibration/EcalCalibAlgos

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@lpernie
Copy link
Contributor

lpernie commented Sep 6, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22748/console Started: 2017/09/06 15:08

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

Pull request #20399 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

Pull request #20399 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please check and sign again.

@lpernie
Copy link
Contributor

lpernie commented Sep 6, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22755/console Started: 2017/09/06 17:11

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

Pull request #20399 was updated. @ghellwig, @kkousour, @arunhep, @cerminar, @fabozzi, @cmsbuild, @franzoni, @kpedro88, @GurpreetSinghChahal, @lpernie can you please check and sign again.

@arunhep
Copy link
Contributor

arunhep commented Sep 8, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22829/console Started: 2017/09/09 00:20

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20399/22829/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2641982
  • DQMHistoTests: Total failures: 203
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2641590
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@fabozzi
Copy link
Contributor

fabozzi commented Sep 12, 2017

+1

@arunhep
Copy link
Contributor

arunhep commented Sep 12, 2017

+1

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 461787c into cms-sw:CMSSW_9_3_X Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants