island photons for XeXe collision era + HI pp reference run era and relval wf (92X) #21070

ttrk · 2017-10-30T06:12:08Z

fixes the pp_on_XeXe_2017 era to run island photons and add them into event content
original 92X PR for pp_on_XeXe_2017 era : #20760
adds "Run2_2017_ppRef" era to run customized reco for HI pp reference run
adds a corresponding relval wf (149)
runs and stores photonIsolationHIProducer objects using the era
backport of #20929 and #21122

apply the era modifiers to the original definitions in RecoEcal/EgammaClusterProducers as suggested here cms-sw#20929 (comment) and here cms-sw#20929 (comment)

cmsbuild · 2017-10-30T06:12:28Z

A new Pull Request was created by @ttrk (Kaya Tatar) for CMSSW_9_2_X.

It involves the following packages:

RecoEcal/Configuration
RecoEcal/EgammaClusterProducers
RecoEgamma/Configuration
RecoEgamma/EgammaPhotonProducers
RecoHI/HiEgammaAlgos

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @varuns23, @rovere, @argiro, @yenjie, @jazzitup, @kurtejung, @lgray, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

perrotta · 2017-10-30T08:39:26Z

please test

cmsbuild · 2017-10-30T08:39:42Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24040/console Started: 2017/10/30 09:42

cmsbuild · 2017-10-30T10:07:35Z

+1
Tested at: 472316f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21070/24040/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
33acb25
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21070/24040/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21070/24040/git-merge-result

cmsbuild · 2017-10-30T10:07:38Z

Comparison job queued.

cmsbuild · 2017-10-30T11:52:50Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21070/24040/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 2160393
DQMHistoTests: Total failures: 14535
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2145686
DQMHistoTests: Total skipped: 172
DQMHistoTests: Total Missing objects: 0
Checked 94 log files, 9 edm output root files, 23 DQM output files

perrotta · 2017-10-30T13:16:45Z

+1

Functionally identical to island photons for XeXe collision era #20929, submitted to the master (by now 10_X)

cmsbuild · 2017-10-30T13:17:03Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2017-10-30T15:19:34Z

By the way, @ttrk et al.: Which are the plans for this PR? Do you need to have it actually backported to 92X? If so, when? (I.e. should we ask a 92X release with it as soon as merged?)

ttrk · 2017-10-30T15:29:53Z

The PR for 92X is needed, because the current version does not work as it should. The timeline depends on the new PR that I mentioned here #20929 (comment).
If the pp ref run is to be taken with 92X, then I assume this 92X PR becomes more urgent to merge so that I can make the PR for pp reference era.
I think a new release for this 92X PR is not urgent, because there is no plan to re-reco xexe data with 92X, the xexe re-reco will be with 94X.

mandrenguyen · 2017-11-01T18:30:55Z

Can we merge this so we submit a 2nd PR adding a pp at 5TeV era? The run is (might be?) around the corner.

slava77 · 2017-11-02T14:56:27Z

Can we merge this so we submit a 2nd PR adding a pp at 5TeV era? The run is (might be?) around the corner.

the issue with the backports is that chained integration is not really supported. So, if you need this plus something else, you will need to make a combined PR.

cmsbuild · 2017-11-07T02:57:50Z

Pull request #21070 was updated. @perrotta, @prebello, @kpedro88, @fabozzi, @cmsbuild, @franzoni, @slava77, @GurpreetSinghChahal, @davidlange6 can you please check and sign again.

slava77 · 2017-11-07T08:15:49Z

@cmsbuild please test

cmsbuild · 2017-11-07T08:16:10Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24223/console Started: 2017/11/07 09:17

cmsbuild · 2017-11-07T10:28:37Z

+1
Tested at: 910c964
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21070/24223/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
33acb25
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21070/24223/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21070/24223/git-merge-result

cmsbuild · 2017-11-07T10:28:41Z

Comparison job queued.

perrotta · 2017-11-07T10:38:01Z

After going through all lines of this PR I verified that it is a faithful copy of the merging of the two PRs #20929 and #21122, which are meant to be backported in 92X

cmsbuild · 2017-11-07T12:36:06Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21070/24223/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 2160359
DQMHistoTests: Total failures: 44287
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2115900
DQMHistoTests: Total skipped: 172
DQMHistoTests: Total Missing objects: 0
Checked 94 log files, 9 edm output root files, 23 DQM output files

perrotta · 2017-11-07T13:43:25Z

+1

Backport needed for the ppref run at 5 TeV
Configuration changes are driver by the corresponding era, and coincide with the ones already merged in the master

kpedro88 · 2017-11-07T15:49:38Z

+1

fabozzi · 2017-11-07T15:55:39Z

+1

davidlange6 · 2017-11-07T17:17:48Z

merge

slava77 · 2017-11-10T13:28:01Z

Configuration/DataProcessing/python/Impl/ppEra_Run2_2017_ppRef.py

+        self.recoSeq=''
+        self.cbSc='pp'
+        self.addEI=True
+        self.isRepacked=True


oops. This is wrong.
It should be set to false.
https://hypernews.cern.ch/HyperNews/CMS/get/tier0-Ops/1776/1/1/1/1/1/1/1/2/1/1/2/1/1/1.html

Do you want a new 92X PR for this ? Also should there be new PRs for 94X and master branch ?

I made a PR for 92X and for master.
There is no need for 94X because T0 is not going to switch to 94X and this scenario.

PRs with fixes are in #21255 and #21256

fix the pp_on_XeXe_2017 era to run and store island photons

472316f

apply the era modifiers to the original definitions in RecoEcal/EgammaClusterProducers as suggested here cms-sw#20929 (comment) and here cms-sw#20929 (comment)

cmsbuild added this to the CMSSW_9_2_X milestone Oct 30, 2017

cmsbuild added comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Oct 30, 2017

ttrk mentioned this pull request Oct 30, 2017

island photons for XeXe collision era #20929

Merged

cmsbuild added tests-started and removed tests-pending labels Oct 30, 2017

cmsbuild added tests-approved and removed tests-started labels Oct 30, 2017

cmsbuild added comparison-available and removed comparison-pending labels Oct 30, 2017

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Oct 30, 2017

cmsbuild added comparison-pending tests-pending and removed tests-approved labels Nov 7, 2017

cmsbuild added tests-started and removed tests-pending labels Nov 7, 2017

cmsbuild added tests-approved and removed tests-started labels Nov 7, 2017

cmsbuild added comparison-available and removed comparison-pending labels Nov 7, 2017

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Nov 7, 2017

cmsbuild added upgrade-approved and removed upgrade-pending labels Nov 7, 2017

cmsbuild added pdmv-approved and removed pdmv-pending labels Nov 7, 2017

cmsbuild added orp-approved and removed orp-pending labels Nov 7, 2017

cmsbuild merged commit 1fcd76c into cms-sw:CMSSW_9_2_X Nov 7, 2017

slava77 reviewed Nov 10, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

island photons for XeXe collision era + HI pp reference run era and relval wf (92X) #21070

island photons for XeXe collision era + HI pp reference run era and relval wf (92X) #21070

ttrk commented Oct 30, 2017 •

edited

Loading

cmsbuild commented Oct 30, 2017

perrotta commented Oct 30, 2017

cmsbuild commented Oct 30, 2017 •

edited

Loading

cmsbuild commented Oct 30, 2017

cmsbuild commented Oct 30, 2017

cmsbuild commented Oct 30, 2017

perrotta commented Oct 30, 2017

cmsbuild commented Oct 30, 2017

perrotta commented Oct 30, 2017

ttrk commented Oct 30, 2017

mandrenguyen commented Nov 1, 2017

slava77 commented Nov 2, 2017

cmsbuild commented Nov 7, 2017

slava77 commented Nov 7, 2017

cmsbuild commented Nov 7, 2017 •

edited

Loading

cmsbuild commented Nov 7, 2017

cmsbuild commented Nov 7, 2017

perrotta commented Nov 7, 2017

cmsbuild commented Nov 7, 2017

perrotta commented Nov 7, 2017

kpedro88 commented Nov 7, 2017

fabozzi commented Nov 7, 2017

davidlange6 commented Nov 7, 2017

slava77 Nov 10, 2017

ttrk Nov 10, 2017

slava77 Nov 10, 2017

slava77 Nov 10, 2017

island photons for XeXe collision era + HI pp reference run era and relval wf (92X) #21070

island photons for XeXe collision era + HI pp reference run era and relval wf (92X) #21070

Conversation

ttrk commented Oct 30, 2017 • edited Loading

cmsbuild commented Oct 30, 2017

perrotta commented Oct 30, 2017

cmsbuild commented Oct 30, 2017 • edited Loading

cmsbuild commented Oct 30, 2017

cmsbuild commented Oct 30, 2017

cmsbuild commented Oct 30, 2017

perrotta commented Oct 30, 2017

cmsbuild commented Oct 30, 2017

perrotta commented Oct 30, 2017

ttrk commented Oct 30, 2017

mandrenguyen commented Nov 1, 2017

slava77 commented Nov 2, 2017

cmsbuild commented Nov 7, 2017

slava77 commented Nov 7, 2017

cmsbuild commented Nov 7, 2017 • edited Loading

cmsbuild commented Nov 7, 2017

cmsbuild commented Nov 7, 2017

perrotta commented Nov 7, 2017

cmsbuild commented Nov 7, 2017

perrotta commented Nov 7, 2017

kpedro88 commented Nov 7, 2017

fabozzi commented Nov 7, 2017

davidlange6 commented Nov 7, 2017

slava77 Nov 10, 2017

Choose a reason for hiding this comment

ttrk Nov 10, 2017

Choose a reason for hiding this comment

slava77 Nov 10, 2017

Choose a reason for hiding this comment

slava77 Nov 10, 2017

Choose a reason for hiding this comment

ttrk commented Oct 30, 2017 •

edited

Loading

cmsbuild commented Oct 30, 2017 •

edited

Loading

cmsbuild commented Nov 7, 2017 •

edited

Loading