New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add displacedJet skim / add relval steps / add RAW+AOD event content #21260
Conversation
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @kfjack (Kai-Feng Chen) for master. It involves the following packages: Configuration/EventContent @prebello, @kpedro88, @fabozzi, @cmsbuild, @franzoni, @GurpreetSinghChahal, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test workflow 136.804 |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
-1 Tested at: 11845f1 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
@fabiocos , although all workflow in the above tests ran fine but there was this error in the runTheMatrix output https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21260/25410/runTheMatrix-results/matrixTests.log
as cms-bot just grep for 'ERROR' in this file that is why it assumed that something failed. |
please test |
The tests are being triggered in jenkins. |
@@ -251,6 +251,7 @@ | |||
workflows[136.801] = ['',['RunZeroBias2017C','HLTDR2_2017','RECODR2_2017reHLT_Prompt','HARVEST2017']] | |||
workflows[136.802] = ['',['RunMuOnia2017C','HLTDR2_2017','RECODR2_2017reHLT_skimMuOnia_Prompt','HARVEST2017']] | |||
workflows[136.803] = ['',['RunNoBPTX2017C','HLTDR2_2017','RECODR2_2017reHLTAlCaTkCosmics_Prompt','HARVEST2017']] | |||
workflows[136.804] = ['',['RunDisplacedJet2017C','HLTDR2_2017','RECODR2_2017reHLT_skimDisplacedJet_Prompt','HARVEST2017']] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabiocos , I think runTheMatrix complain about this override?
I think this PR needs a rebase, since new relvals have been introduced since when this was originally deployed. |
-1 Tested at: 11845f1 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
So I guess I should restart a new PR with new CMSSW? Will do that in a moment. |
@kfjack Either you modify this PR or open a new one, and we close this one... |
Ok, I just tried a quick rebase but the local test also failed. Will restart from a clean release again (will be a new PR in this case). |
Hi all, I managed to restart a new PR #21857 with a clean new IB. I will close this PR in a moment. |
Integrate all of the modifications from PR #20948: