Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relval steps for DisplacedJet PD + RAW-AOD event content + EXODisplacedJet skim #20948

Closed
wants to merge 3 commits into from

Conversation

kfjack
Copy link
Contributor

@kfjack kfjack commented Oct 18, 2017

Rebased from #20738:
Add relval steps for DisplacedJet PD
Add RAW-AOD event content
Add/modify EXODisplacedJet skim

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20948/1506

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kfjack (Kai-Feng Chen) for master.

It involves the following packages:

Configuration/EventContent
Configuration/PyReleaseValidation
Configuration/Skimming

@prebello, @kpedro88, @fabozzi, @cmsbuild, @franzoni, @GurpreetSinghChahal, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @felicepantaleo, @ebrondol, @Martin-Grunewald, @makortel this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@fabozzi
Copy link
Contributor

fabozzi commented Oct 18, 2017

please test workflow 136.804

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23836/console Started: 2017/10/18 09:44

@cmsbuild
Copy link
Contributor

-1

Tested at: 1a352e0

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
9ce9166
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20948/23836/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20948/23836/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20948/23836/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
136.804 step2

runTheMatrix-results/136.804_RunDisplacedJet2017C+RunDisplacedJet2017C+HLTDR2_2017+RECODR2_2017reHLT_skimDisplacedJet_Prompt+HARVEST2017/step2_RunDisplacedJet2017C+RunDisplacedJet2017C+HLTDR2_2017+RECODR2_2017reHLT_skimDisplacedJet_Prompt+HARVEST2017.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
9ce9166
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20948/23836/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20948/23836/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@fabozzi
Copy link
Contributor

fabozzi commented Oct 18, 2017

please test workflow 136.804

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23848/console Started: 2017/10/18 14:44

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20948/23848/summary.html

There are some workflows for which there are errors in the baseline:
10042.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2582123
  • DQMHistoTests: Total failures: 100
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2581859
  • DQMHistoTests: Total skipped: 164
  • DQMHistoTests: Total Missing objects: 0
  • Checked 102 log files, 10 edm output root files, 25 DQM output files

@jingyuluo
Copy link
Contributor

Hi @fabozzi , the output EventContent seems fine for me.

Thanks,
Jingyu

@fabozzi
Copy link
Contributor

fabozzi commented Oct 18, 2017

+1

@jingyuluo
Copy link
Contributor

Hi,

What's the status of this PR? Is there any remaining issue for this to be merged?

Thanks,
Jingyu

@kpedro88
Copy link
Contributor

kpedro88 commented Nov 7, 2017

+1

@davidlange6
Copy link
Contributor

Your PR is unmergeable. Please have a look and possibly rebase it.

@kfjack
Copy link
Contributor Author

kfjack commented Nov 10, 2017 via email

@fabozzi
Copy link
Contributor

fabozzi commented Nov 13, 2017

@kfjack
I have approved the new PR. You can close this one

@kfjack kfjack closed this Nov 13, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants