-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add relval steps for DisplacedJet PD + RAW-AOD event content + EXODisplacedJet skim #20948
Conversation
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @kfjack (Kai-Feng Chen) for master. It involves the following packages: Configuration/EventContent @prebello, @kpedro88, @fabozzi, @cmsbuild, @franzoni, @GurpreetSinghChahal, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test workflow 136.804 |
The tests are being triggered in jenkins. |
-1 Tested at: 1a352e0 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/136.804_RunDisplacedJet2017C+RunDisplacedJet2017C+HLTDR2_2017+RECODR2_2017reHLT_skimDisplacedJet_Prompt+HARVEST2017/step2_RunDisplacedJet2017C+RunDisplacedJet2017C+HLTDR2_2017+RECODR2_2017reHLT_skimDisplacedJet_Prompt+HARVEST2017.log The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
please test workflow 136.804 |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
@kfjack @jingyuluo |
Hi @fabozzi , the output EventContent seems fine for me. Thanks, |
+1 |
Hi, What's the status of this PR? Is there any remaining issue for this to be merged? Thanks, |
+1 |
Your PR is unmergeable. Please have a look and possibly rebase it. |
Ok, I'll try to fix this, with a new PR probably.
Update: I tried to do a rebase in CMSSW_10_X, but it does not work (still cannot merge, although a local test of RelVal works). I'll rebuild everything from scratch.
Update 2: new PR created #21260, from a clean CMSSW_10_0_X_2017-11-10-1100.
… On Nov 10, 2017, at 6:48 AM, David Lange ***@***.***> wrote:
Your PR is unmergeable. Please have a look and possibly rebase it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#20948 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFpZnXfo1HIiqViPEYUtWxGVHU220E9Yks5s0-O5gaJpZM4P9GjA>.
|
@kfjack |
Rebased from #20738:
Add relval steps for DisplacedJet PD
Add RAW-AOD event content
Add/modify EXODisplacedJet skim