Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improving dynamic inefficiency monitoring (backport) #23062

Merged
merged 1 commit into from Jun 7, 2018
Merged

improving dynamic inefficiency monitoring (backport) #23062

merged 1 commit into from Jun 7, 2018

Conversation

fioriNTU
Copy link
Contributor

backport of #23061

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2018

A new Pull Request was created by @fioriNTU for CMSSW_10_1_X.

It involves the following packages:

DQM/SiPixelPhase1Clusters
DQM/SiPixelPhase1DeadFEDChannels
DQM/SiPixelPhase1Digis
DQM/SiPixelPhase1TrackClusters

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @hdelanno this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27664/console Started: 2018/04/26 18:20

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23062/27664/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2506331
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 10192
  • DQMHistoTests: Total successes: 2495959
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 262.93 KiB( 28 files compared)
  • DQMHistoSizes: changed ( 1306.0,... ): 0.008 KiB L1T/EventInfo
  • DQMHistoSizes: changed ( 1306.0,... ): 0.008 KiB L1TEMU/EventInfo
  • DQMHistoSizes: changed ( 1306.0,... ): 0.008 KiB RPC/EventInfo
  • DQMHistoSizes: changed ( 1306.0,... ): 0.007 KiB Tracking/EventInfo
  • DQMHistoSizes: changed ( 1306.0,... ): 0.005 KiB SiStrip/EventInfo
  • DQMHistoSizes: changed ( 1306.0,... ): 0.005 KiB Ecal/EventInfo
  • DQMHistoSizes: changed ( 1306.0,... ): 0.005 KiB Pixel/EventInfo
  • DQMHistoSizes: changed ( 1306.0,... ): 0.004 KiB Muons/EventInfo
  • DQMHistoSizes: changed ( 1306.0,... ): 0.003 KiB RecoTauV/EventInfo
  • DQMHistoSizes: changed ( 1306.0,... ): 0.003 KiB HLT/EventInfo
  • DQMHistoSizes: changed ( 1306.0 ): ...
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fioriNTU
Copy link
Contributor Author

@fabiocos can this be merged?

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 28, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28223/console Started: 2018/05/28 10:40

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23062/28223/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2500582
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 10192
  • DQMHistoTests: Total successes: 2490210
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 261.784 KiB( 28 files compared)
  • DQMHistoSizes: changed ( 10042.0,... ): 242.566 KiB PixelPhase1/Tracks
  • DQMHistoSizes: changed ( 10042.0,... ): -209.844 KiB PixelPhase1/Phase1_MechanicalView
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Jun 7, 2018

+1

master version validated in CMSSW_10_2_0_pre4, no problem reported

@cmsbuild cmsbuild merged commit bb612c9 into cms-sw:CMSSW_10_1_X Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants