Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improving dynamic inefficiency monitoring (backport) #23062

Merged
merged 1 commit into from
Jun 7, 2018
Merged

improving dynamic inefficiency monitoring (backport) #23062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions DQM/SiPixelPhase1Clusters/python/SiPixelPhase1Clusters_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
SiPixelPhase1ClustersNClusters = DefaultHistoDigiCluster.clone(
name = "clusters",
title = "Clusters",
range_min = 0, range_max = 30, range_nbins = 60,
range_min = 0, range_max = 100, range_nbins = 25,
xlabel = "clusters",
dimensions = 0,

Expand Down Expand Up @@ -226,7 +226,7 @@
SiPixelPhase1ClustersReadoutNClusters = DefaultHistoReadout.clone(
name = "clusters",
title = "Clusters",
range_min = 0, range_max = 30, range_nbins = 30,
range_min = 0, range_max = 100, range_nbins = 25,
xlabel = "clusters",
dimensions = 0,
specs = VPSet(
Expand Down
4 changes: 1 addition & 3 deletions DQM/SiPixelPhase1DeadFEDChannels/python/SiPixelPhase1DeadFEDChannels_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
name = "Dead Channels",
title = "Dead Channels",
xlabel = "dead channels",
#range_min = 1199.5, range_max = 1338.5, range_nbins = 139,
range_min = 0, range_max = 1000, range_nbins = 100,
dimensions = 0,
specs = VPSet(
Expand All @@ -27,7 +26,7 @@
.groupBy("FED","EXTEND_X")
.groupBy("","EXTEND_Y")
.save(), #average dead channels per event and FED per LumiBlock
Specification().groupBy("LumiBlock/Event")
Specification().groupBy("PXAll/Event")
.reduce("COUNT")
.groupBy("LumiBlock") #average number of dead channels per Lumisection
.reduce("MEAN")
Expand Down Expand Up @@ -83,7 +82,6 @@
name = "Dead Channels per ROC",
title = "Dead Channels per ROC",
xlabel = "dead channels per ROC",
#range_min = 1199.5, range_max = 1338.5, range_nbins = 139,
range_min = 0, range_max = 1000, range_nbins = 100,
dimensions = 0,
specs = VPSet(
Expand Down
8 changes: 4 additions & 4 deletions DQM/SiPixelPhase1Digis/python/SiPixelPhase1Digis_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
title = "Digis",
xlabel = "digis",
range_min = 0,
range_max = 200,
range_nbins = 100,
range_max = 300,
range_nbins = 50,
dimensions = 0, # this is a count

specs = VPSet(
Expand All @@ -38,11 +38,11 @@
Specification().groupBy("PXBarrel/PXLayer/Event") #this will produce inclusive counts per Layer/Disk
.reduce("COUNT")
.groupBy("PXBarrel/PXLayer")
.save(nbins=100, xmin=0, xmax=20000),
.save(nbins=100, xmin=0, xmax=40000),
Specification().groupBy("PXForward/PXDisk/Event")
.reduce("COUNT")
.groupBy("PXForward/PXDisk/")
.save(nbins=100, xmin=0, xmax=10000),
.save(nbins=100, xmin=0, xmax=20000),
)
)

Expand Down
28 changes: 28 additions & 0 deletions DQM/SiPixelPhase1TrackClusters/python/SiPixelPhase1TrackClusters_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,9 +299,36 @@
.groupBy("PXForward/HalfCylinder/PXRing/PXDisk/SignedBlade/PXModuleName/row", "EXTEND_X")
.groupBy("PXForward/HalfCylinder/PXRing/PXDisk/SignedBlade/PXModuleName", "EXTEND_Y")
.save(),
StandardSpecificationOccupancy,
)
)

SiPixelPhase1DigisNdigisOnTrack = DefaultHistoTrack.clone(
name = "digis on-track", # 'Count of' added automatically
title = "Digis on-track",
xlabel = "digis (on-track)",
range_min = 0,
range_max = 300,
range_nbins = 50,
dimensions = 0, # this is a count

specs = VPSet(
StandardSpecificationTrend_Num,
StandardSpecification2DProfile_Num,

Specification().groupBy("PXBarrel/PXLayer/Event") #this will produce inclusive counts per Layer/Disk
.reduce("COUNT")
.groupBy("PXBarrel/PXLayer")
.save(nbins=100, xmin=0, xmax=40000),
Specification().groupBy("PXForward/PXDisk/Event")
.reduce("COUNT")
.groupBy("PXForward/PXDisk/")
.save(nbins=100, xmin=0, xmax=20000),
)
)



SiPixelPhase1TrackClustersNTracks = DefaultHistoTrack.clone(
name = "ntracks",
title = "Number of Tracks",
Expand Down Expand Up @@ -469,6 +496,7 @@
SiPixelPhase1TrackClustersOnTrackPositionB,
SiPixelPhase1TrackClustersOnTrackPositionF,
SiPixelPhase1DigisHitmapOnTrack,
SiPixelPhase1DigisNdigisOnTrack,

SiPixelPhase1TrackClustersNTracks,
SiPixelPhase1TrackClustersNTracksInVolume,
Expand Down
3 changes: 3 additions & 0 deletions DQM/SiPixelPhase1TrackClusters/src/SiPixelPhase1TrackClusters.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ enum {
ON_TRACK_POSITIONB,
ON_TRACK_POSITIONF,
DIGIS_HITMAP_ON_TRACK,
ON_TRACK_NDIGIS,

NTRACKS,
NTRACKS_INVOLUME,
Expand Down Expand Up @@ -246,6 +247,7 @@ void SiPixelPhase1TrackClusters::analyze(const edm::Event& iEvent, const edm::Ev
for (int i = 0; i < cluster.size(); i++){
SiPixelCluster::Pixel const & vecipxl = cluster.pixel(i);
histo[DIGIS_HITMAP_ON_TRACK].fill(id, &iEvent, vecipxl.y, vecipxl.x);
histo[ON_TRACK_NDIGIS].fill(id, &iEvent);
}

histo[ON_TRACK_NCLUSTERS].fill(id, &iEvent);
Expand Down Expand Up @@ -287,6 +289,7 @@ void SiPixelPhase1TrackClusters::analyze(const edm::Event& iEvent, const edm::Ev
}

histo[ON_TRACK_NCLUSTERS].executePerEventHarvesting(&iEvent);
histo[ON_TRACK_NDIGIS].executePerEventHarvesting(&iEvent);
}

} // namespace
Expand Down