HCALDQM: Require HB/HE for QIE11 and HF for QIE10 #23262
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23262/4746 |
|
A new Pull Request was created by @DryRun (David Yu) for master. It involves the following packages: DQM/HcalTasks @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test
…________________________________________
From: cmsbuild [notifications@github.com]
Sent: 20 May 2018 01:05
To: cms-sw/cmssw
Cc: Javier Fernandez Menendez; Mention
Subject: Re: [cms-sw/cmssw] HCALDQM: Require HB/HE for QIE11 and HF for QIE10 (#23262)
A new Pull Request was created by @DryRun<https://github.com/DryRun> (David Yu) for master.
It involves the following packages:
DQM/HcalTasks
@vazzolini<https://github.com/vazzolini>, @kmaeshima<https://github.com/kmaeshima>, @dmitrijus<https://github.com/dmitrijus>, @cmsbuild<https://github.com/cmsbuild>, @jfernan2<https://github.com/jfernan2>, @vanbesien<https://github.com/vanbesien> can you please review it and eventually sign? Thanks.
@deguio<https://github.com/deguio> this is something you requested to watch as well.
@davidlange6<https://github.com/davidlange6>, @slava77<https://github.com/slava77>, @fabiocos<https://github.com/fabiocos> you are the release manager for this.
cms-bot commands are listed here<http://cms-sw.github.io/cms-bot-cmssw-cmds.html>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#23262 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AETJ6WnTjtiQhCyAmZZgIzgGY9r7s4C4ks5t0KVIgaJpZM4UF4ru>.
|
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
@DryRun thank you for the quick fix |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
@DryRun I assume this protection is needed in 10_1_X as well, right? |
This PR addresses #23259. DigiPhase1Task is crashing due to calibration DetIds in the QIE10/11 digi collections (the DetIds are not in the emap, so histograms are not created for them).
It's not entirely obvious to me why this crash is only occurring now, but this fix should have no impact on the intended behavior of the module (which is no longer used, anyways).