HCALDQM: Require HB/HE for QIE11 and HF for QIE10 (9_4_X backport)

[DryRun]

PR description:

This PR addresses issue #27456, which we believe is the 9_4_X version of the year-old (solved) issue #23259.

DigiPhase1Task is crashing due to calibration DetIds in the QIE10/11 digi collections (the DetIds are not in the emap, so histograms are not created for them).

It's not entirely obvious to me why this crash is only occurring now, but this fix should have no impact on the intended behavior of the module (which is no longer used, anyways).

PR validation:

Successfully ran runTheMatrix with the following workflows:

10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017
11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+ALCAFull_2019+HARVESTFull_2019
136.795_RunJetHT2017C+RunJetHT2017C+HLTDR2_2017+RECODR2_2017reHLT_skimJetHT_Prompt+HARVEST2017

as well as the cmsDriver command provided by @franzoni (starting from 136.795 step1 and step2):

cmsDriver.py Configuration/GenProduction/python/superfragment_cfi.py --fileout file:HiggsLLP_test.GENSIM.root --mc --eventcontent RAWSIM --datatier GEN-SIM --conditions 102X_upgrade2018_realistic_v11 --beamspot Realistic25ns13TeVEarly2018Collision --customise_commands="process.source.numberEventsInLuminosityBlock = cms.untracked.uint32(10)" --step GEN,SIM --nThreads 8 --geometry DB:Extended --era Run2_2018 --python_filename superfragment_cfg.py --no_exec --customise Configuration/DataProcessing/Utils.addMonitoring -n 100

if this PR is a backport please specify the original PR:

#23262

[cmsbuild]

A new Pull Request was created by @DryRun (David Yu) for CMSSW_9_4_X.

It involves the following packages:

DQM/HcalTasks

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@deguio this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1387/console Started: 2019/07/10 09:25

[cmsbuild]

+1
Tested at: d1d5126
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-754266/1387/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-754266/1387/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2721493
• DQMHistoTests: Total failures: 111
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2721220
• DQMHistoTests: Total skipped: 162
• DQMHistoTests: Total Missing objects: 0

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[franzoni]

hello @DryRun DryRun
Can you please make sure that in parallel to the PR review, the crash is reproduced and the fix tested on the actually crashing events? Pls
PdmV can help providing configs/files to reproduce the problem ( the crash is rare and needs a targeted selection of input file to be reproduced)
Tkx!
@prebello @pgunnell @zhenhu

[DryRun]

Hi @franzoni - certainly, I can try to do this in the next couple days!

[fabiocos]

@DryRun @franzoni @srimanob in principle this backport corresponds with the fixe merged more than one year ago, so i would say it is ok to go. Probably before making the release build it would be good to have the confirmation that this is the end of the story and it solves the observed problem

[fabiocos]

+1